-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[1.21] ci/gha: fixup golangci-lint job #5918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21] ci/gha: fixup golangci-lint job #5918
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.21 #5918 +/- ##
=============================================
Coverage 44.97% 44.97%
=============================================
Files 109 109
Lines 11063 11063
=============================================
Hits 4976 4976
Misses 5608 5608
Partials 479 479 |
This comment was marked as outdated.
This comment was marked as outdated.
Apparently, ubuntu-latest now comes with a recent version of golang, which is too new for golangci-lint we use in this branch. As a result, we have errors like ...could not import internal/goarch (-: could not load export data: cannot import \"internal/goarch\" (unknown iexport format version 2), export data is newer version - update tool)))))]]" Explicitly installing golang 1.16 and updating the action itself (v3 relies on installed golang) should fix the issue. Signed-off-by: Kir Kolyshkin <[email protected]>
e97bf21 to
4481d52
Compare
|
OK, updating the action itself helped |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Apparently, ubuntu-latest now comes with a recent version of golang,
which is too new for golangci-lint we use in this branch. As a result,
we have errors like
Explicitly installing golang 1.16 and upgrading the action itself should fix the issue.
/kind ci