Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: set cri stats more idiomatically #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 2, 2022
Merged

test: set cri stats more idiomatically #5926

openshift-merge-robot merged 1 commit into from
Jun 2, 2022

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Jun 1, 2022

by changing the socket to a symlinked location

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

fixes #5923

(though we should figure out why it's failing on fedora in the first place)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@haircommander
test: set cri stats more idiomatically
2fbf719 
by changing the socket to a symlinked location

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 1, 2022
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl June 1, 2022 20:15
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2022

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/kata-jenkins 2fbf719 link true /test kata-containers
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 2fbf719 link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

saschagrunert
saschagrunert approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

saschagrunert commented Jun 2, 2022

/override e2e-agnostic
/override e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@saschagrunert: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e-agnostic
  • e2e-gcp

Only the following contexts were expected:

  • ci/kata-jenkins
  • ci/openshift-jenkins/critest_fedora
  • ci/openshift-jenkins/critest_rhel
  • ci/openshift-jenkins/e2e_crun
  • ci/openshift-jenkins/e2e_crun_cgroupv2
  • ci/openshift-jenkins/e2e_features_fedora
  • ci/openshift-jenkins/e2e_features_rhel
  • ci/openshift-jenkins/e2e_fedora
  • ci/openshift-jenkins/e2e_rhel
  • ci/openshift-jenkins/integration_crun
  • ci/openshift-jenkins/integration_crun_cgroupv2
  • ci/openshift-jenkins/integration_fedora
  • ci/openshift-jenkins/integration_rhel
  • ci/prow/e2e-agnostic
  • ci/prow/e2e-gcp
  • ci/prow/images
  • dco
  • kata-containers-2-crio-PR
  • pull-ci-cri-o-cri-o-main-e2e-agnostic
  • pull-ci-cri-o-cri-o-main-e2e-gcp
  • pull-ci-cri-o-cri-o-main-images
  • test_pull_request_crio_critest_fedora
  • test_pull_request_crio_critest_rhel
  • test_pull_request_crio_e2e_crun_fedora
  • test_pull_request_crio_e2e_crun_fedora_cgroupv2
  • test_pull_request_crio_e2e_features_fedora
  • test_pull_request_crio_e2e_features_rhel
  • test_pull_request_crio_e2e_fedora
  • test_pull_request_crio_e2e_rhel
  • test_pull_request_crio_integration_crun_fedora
  • test_pull_request_crio_integration_crun_fedora_cgroupv2
  • test_pull_request_crio_integration_fedora
  • test_pull_request_crio_integration_rhel
  • tide
Details

In response to this:

/override e2e-agnostic
/override e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

saschagrunert commented Jun 2, 2022

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-agnostic, ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

saschagrunert commented Jun 2, 2022

/override ci/kata-jenkins

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/kata-jenkins

Details

In response to this:

/override ci/kata-jenkins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert mentioned this pull request Jun 2, 2022
Closed
@openshift-merge-robot openshift-merge-robot merged commit e86f723 into cri-o:main Jun 2, 2022
@haircommander
Copy link
Member Author

haircommander commented Jun 9, 2022

/cherry-pick release-1.24

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 9, 2022

@haircommander: new pull request created: #5959

Details

In response to this:

/cherry-pick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2022
Merged
@saschagrunert saschagrunert mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pod eviction e2e tests fail

5 participants

@haircommander @openshift-ci-robot @saschagrunert @openshift-cherrypick-robot @openshift-merge-robot