server: update container status if state has bogus information #6023
Conversation
2f0a5a7 to
31981ce
Compare
saschagrunert
left a comment
There was a problem hiding this comment.
LGTM, I assume we cannot reproduce this scenario and therefore have no integration test for it?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if CreatedAt is zero, the Kubelet will complain and also be confused by the container. Attempt to update in this case. Signed-off-by: Peter Hunt <[email protected]>
31981ce to
98043cc
Compare
|
no reproducer yet, but I did add a unit test :) |
Codecov Report
@@ Coverage Diff @@
## main #6023 +/- ##
==========================================
+ Coverage 42.74% 42.78% +0.03%
==========================================
Files 119 119
Lines 12620 12627 +7
==========================================
+ Hits 5395 5402 +7
Misses 6705 6705
Partials 520 520 |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
possible alternative to this: #6026 if we go that route, we could potentially backport this fix to older branches, and leave that one for 1.25 |
|
LGTM |
|
replaced by #6122 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
if CreatedAt is zero, the Kubelet will complain and also be confused by the container.
Attempt to update in this case.
Signed-off-by: Peter Hunt [email protected]
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?