Thanks to visit codestin.com
Credit goes to github.com

Skip to content

migrate image_list to quay.io #6106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 31, 2022
Merged

migrate image_list to quay.io #6106

openshift-merge-robot merged 1 commit into from
Jul 31, 2022

Conversation

@rphillips
Copy link
Contributor

@rphillips rphillips commented Jul 29, 2022 •
edited
Loading

Migrates more images to quay.io

NONE

@rphillips rphillips requested review from mrunalp and runcom as code owners July 29, 2022 22:28
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl July 29, 2022 22:28
@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 29, 2022
@rphillips rphillips mentioned this pull request Jul 29, 2022
Closed
@rphillips rphillips force-pushed the migrate_image_list branch from d553ee9 to 0b34a2f Compare July 29, 2022 22:29
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 29, 2022
mrunalp
mrunalp approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #6106 (e82c16b) into main (6b8ba7f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6106   +/-   ##
=======================================
  Coverage   42.88%   42.88%           
=======================================
  Files         117      117           
  Lines       12733    12733           
=======================================
  Hits         5461     5461           
  Misses       6720     6720           
  Partials      552      552

@openshift-bot
Copy link

openshift-bot commented Jul 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link

openshift-bot commented Jul 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member

haircommander commented Jul 30, 2022

/hold

I'm not sure this is working

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2022
@rphillips
migrate image_list to quay.io
e82c16b 
Signed-off-by: Ryan Phillips <[email protected]>
@rphillips rphillips force-pushed the migrate_image_list branch from 0b34a2f to e82c16b Compare July 30, 2022 17:19
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2022
@rphillips
Copy link
Contributor Author

rphillips commented Jul 30, 2022

Thanks @haircommander. I updated the hashes once more... let's see if that helps.

@haircommander
Copy link
Member

haircommander commented Jul 30, 2022

/retest

1 similar comment
@haircommander
Copy link
Member

haircommander commented Jul 30, 2022

/retest

@rphillips
Copy link
Contributor Author

rphillips commented Jul 31, 2022

Looks like that might have helped. PR needs a lgtm. Were the extra retests for another flake or docker.io image I missed?

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2022
@haircommander
Copy link
Member

haircommander commented Jul 31, 2022

It was for ci-integration, though I didn't look into why it failed

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit e3cef0a into cri-o:main Jul 31, 2022
@rphillips rphillips deleted the migrate_image_list branch July 31, 2022 14:29
@haircommander
Copy link
Member

haircommander commented Sep 29, 2022

/cherry-pick release-1.24

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 29, 2022

@haircommander: #6106 failed to apply on top of branch "release-1.24":

Applying: migrate image_list to quay.io
.git/rebase-apply/patch:20: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A	contrib/test/ci/critest_images.yml
A	contrib/test/ci/sync_images.sh
M	test/image.bats
Falling back to patching base and 3-way merge...
Auto-merging test/image.bats
CONFLICT (modify/delete): contrib/test/ci/sync_images.sh deleted in HEAD and modified in migrate image_list to quay.io. Version migrate image_list to quay.io of contrib/test/ci/sync_images.sh left in tree.
CONFLICT (modify/delete): contrib/test/ci/critest_images.yml deleted in HEAD and modified in migrate image_list to quay.io. Version migrate image_list to quay.io of contrib/test/ci/critest_images.yml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 migrate image_list to quay.io
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@mrunalp mrunalp

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rphillips @openshift-bot @haircommander @openshift-cherrypick-robot @mrunalp @openshift-merge-robot