Allow runtime configs to be updated completely #6248
Conversation
|
Hi @elezar. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
f5ecd05 to
5459356
Compare
pkg/config/config.go
Outdated
| } | ||
|
|
||
| // Equals checks whether to runtimes tables are equal. | ||
| func (r Runtimes) Equals(o Runtimes) bool { |
There was a problem hiding this comment.
we could use RuntimesEqual in pkg/config/template.go instead
There was a problem hiding this comment.
Thanks. I have switched to this. One thing that I was concerned about was to ignore ordering in the RuntimeHandler members that are slices but this may be over engineering things at this stage.
Note that I call RuntimesEqual in reload.go directly instead of wrapping it here.
There was a problem hiding this comment.
worst case, we get a false positive because the members are in a different order, and we reload the config. we'll spend some unnecessary cpu time, but it doesn't seem like a horrible case. I think the code succinct-ness is worth it
5459356 to
fe59f4a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elezar, haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fe59f4a to
25b3b9f
Compare
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
25b3b9f to
32e6520
Compare
|
/lgtm |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6248 +/- ##
==========================================
- Coverage 43.70% 43.69% -0.02%
==========================================
Files 122 122
Lines 13662 13659 -3
==========================================
- Hits 5971 5968 -3
Misses 7046 7046
Partials 645 645 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This feature extends the work done for #6056 to allow for complete updates of the runtime configuration. The previous work limited the changes to the runtimes config to adding runtimes and updating the default runtime. These changes allow the complete
crio.runtime.runtimestable to be updated on reload.This was originally discussed in #6036.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?