Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: config tests should ignore default runtime environment variable #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jul 25, 2024
Merged

test: config tests should ignore default runtime environment variable #6280

openshift-merge-bot merged 1 commit into from
Jul 25, 2024

Conversation

@littlejawa
Copy link
Contributor

@littlejawa littlejawa commented Oct 6, 2022

What type of PR is this?

/kind ci

What this PR does / why we need it:

Config tests are meant to verify the configuration code, by exercising it in specific configurations.
When run in an environment where the default runtime is modified, these tests fail because the configuration they use do not have this runtime defined.
As the runtime itself is not involved in these tests, it seems safe to unset the CONTAINER_DEFAULT_RUNTIME variable in their context.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

Hi @littlejawa. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl October 6, 2022 09:52
@codecov
Copy link

codecov bot commented Oct 6, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.53%. Comparing base (6188dad) to head (6e98e42).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6280      +/-   ##
==========================================
- Coverage   49.54%   49.53%   -0.02%     
==========================================
  Files         153      153              
  Lines       17088    17088              
==========================================
- Hits         8466     8464       -2     
- Misses       7558     7559       +1     
- Partials     1064     1065       +1

@littlejawa
Copy link
Contributor Author

littlejawa commented Oct 6, 2022

@haircommander - could you take a look? This is generalizing what we did for your PR #6192

@haircommander
Copy link
Member

haircommander commented Oct 6, 2022

any reason not to do this in setup() instead?

@littlejawa
Copy link
Contributor Author

littlejawa commented Oct 6, 2022

any reason not to do this in setup() instead?

I didn't want to go that far, because some of the tests do not need it : it makes sense only for tests that plays with the default config.

@haircommander
Copy link
Member

haircommander commented Oct 6, 2022

/approve
/ok-to-test
makes sense LGTM

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2022
@littlejawa
Copy link
Contributor Author

littlejawa commented Oct 7, 2022

/retest

1 similar comment
@littlejawa
Copy link
Contributor Author

littlejawa commented Oct 13, 2022

/retest

@github-actions
Copy link

github-actions bot commented Dec 18, 2022

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2022
@haircommander
Copy link
Member

haircommander commented Dec 20, 2022

you've got a shfmt error @littlejawa

@littlejawa littlejawa force-pushed the configtest_unset_default_rt branch from bdef3c9 to 350a9da Compare December 20, 2022 14:45
@littlejawa littlejawa mentioned this pull request Jan 26, 2023
Closed
4 tasks
@littlejawa
Copy link
Contributor Author

littlejawa commented Feb 6, 2023

/retest

@littlejawa
Copy link
Contributor Author

littlejawa commented Feb 8, 2023

/test kata-containers

@littlejawa
Copy link
Contributor Author

littlejawa commented May 15, 2023

@haircommander - this one is pretty old and low priority, but I think it still makes sense.
What do you think?

@haircommander
Copy link
Member

haircommander commented May 15, 2023

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 17, 2024

/retest

@littlejawa littlejawa force-pushed the configtest_unset_default_rt branch from 1bd637b to aa92004 Compare July 17, 2024 08:29
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 17, 2024

/retest

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 17, 2024

/test ci-fedora-kata

@littlejawa
test: config tests should ignore default runtime environment variable
6e98e42 
Config tests are meant to verify the configuration code, by exercising
it in specific configurations.
When run in an environment where the default runtime is modified, these
tests fail because the configuration they use do not have this runtime
defined.
As the runtime itself is not involved in these tests, it seems safe to
unset the CONTAINER_DEFAULT_RUNTIME variable in their context.

Signed-off-by: Julien Ropé <[email protected]>
@littlejawa littlejawa force-pushed the configtest_unset_default_rt branch from aa92004 to 6e98e42 Compare July 17, 2024 15:03
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 17, 2024

/retest

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 17, 2024

/test ci-fedora-kata

1 similar comment
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 18, 2024

/test ci-fedora-kata

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 18, 2024

/retest

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 18, 2024

/test ci-fedora-integration

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 18, 2024

@cri-o/cri-o-maintainers This one has been around for a while, and already approved.
LGTM flag was removed when I added the commit that re-enables the tests for the kata CI. There was no other change.

Can you have a look?

@haircommander
Copy link
Member

haircommander commented Jul 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 19, 2024

/retest

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 19, 2024

/test ci-fedora-integration

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 19, 2024

/retest

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 19, 2024

/test ci-fedora-integration

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 23, 2024

/retest

1 similar comment
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 23, 2024

/retest

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 23, 2024

/test ci-fedora-integration

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 23, 2024

/test ci-cgroupv2-integration

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 23, 2024

/retest

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 24, 2024

/test ci-crun-e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024 •
edited
Loading

@littlejawa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-rhel-integration 350a9da link true /test ci-rhel-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Jul 25, 2024

/override ci/prow/ci-cgroupv2-e2e-crun
/override ci/prow/ci-crun-e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-cgroupv2-e2e-crun, ci/prow/ci-crun-e2e

Details

In response to this:

/override ci/prow/ci-cgroupv2-e2e-crun
/override ci/prow/ci-crun-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f03ce78 into cri-o:main Jul 25, 2024
@littlejawa littlejawa deleted the configtest_unset_default_rt branch August 21, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@saschagrunert saschagrunert

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@littlejawa @haircommander @saschagrunert