Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@haircommander
Copy link
Member

Signed-off-by: Peter Hunt~ [email protected]

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Signed-off-by: Peter Hunt~ <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 6, 2022
@haircommander
Copy link
Member Author

ideally we get #6260 and #6263 first

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 6, 2022
@openshift-ci openshift-ci bot requested review from QiWang19 and fgiudici October 6, 2022 19:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #6283 (959f0ce) into release-1.24 (ac6f687) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.24    #6283   +/-   ##
=============================================
  Coverage         42.85%   42.86%           
=============================================
  Files               124      124           
  Lines             12690    12690           
=============================================
+ Hits               5438     5439    +1     
+ Misses             6730     6729    -1     
  Partials            522      522           

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants