Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable checkpoint image check as early as possible #6342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 28, 2022
Merged

Disable checkpoint image check as early as possible #6342

openshift-merge-robot merged 1 commit into from
Oct 28, 2022

Conversation

@adrianreber
Copy link
Member

@adrianreber adrianreber commented Oct 26, 2022

What type of PR is this?

/kind other

What this PR does / why we need it:

To see if the specified container image is a checkpoint image, each image is checked, if it is a checkpoint image during container create. If checkpoint support is not enabled in CRI-O return as early as possible from this check without even looking at the image.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?

None

@adrianreber
Disable checkpoint image check as early as possible
71252c1 
To see if the specified container image is a checkpoint image, each
image is checked, if it is a checkpoint image during container
create. If checkpoint support is not enabled in CRI-O return as early as
possible from this check without even looking at the image.

Signed-off-by: Adrian Reber <[email protected]>
@adrianreber adrianreber requested a review from mrunalp as a code owner October 26, 2022 16:30
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 26, 2022
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub October 26, 2022 16:30
@openshift-ci openshift-ci bot added kind/other Categorizes issue or PR as not clearly related to any existing kind/* category needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

Hi @adrianreber. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adrianreber
Copy link
Member Author

adrianreber commented Oct 26, 2022

Sorry to reopen this a second time, but GitHub did not accept my force pushed changes to this branch. Let's try it with a new PR.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #6342 (71252c1) into main (94080cf) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6342      +/-   ##
==========================================
- Coverage   44.21%   44.06%   -0.16%     
==========================================
  Files         122      122              
  Lines       13862    13864       +2     
==========================================
- Hits         6129     6109      -20     
- Misses       7061     7083      +22     
  Partials      672      672

saschagrunert
saschagrunert approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianreber, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2022
@adrianreber
Copy link
Member Author

adrianreber commented Oct 26, 2022

/retest-required

1 similar comment
@adrianreber
Copy link
Member Author

adrianreber commented Oct 26, 2022

/retest-required

@saschagrunert
Copy link
Member

saschagrunert commented Oct 26, 2022

/retest

@adrianreber
Copy link
Member Author

adrianreber commented Oct 27, 2022

/retest-required

1 similar comment
@adrianreber
Copy link
Member Author

adrianreber commented Oct 27, 2022

/retest-required

@saschagrunert
Copy link
Member

saschagrunert commented Oct 27, 2022

/override ci/prow/ci-critest
/override ci/prow/ci-integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2022

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-critest, ci/prow/ci-integration

Details

In response to this:

/override ci/prow/ci-critest
/override ci/prow/ci-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adrianreber
Copy link
Member Author

adrianreber commented Oct 28, 2022

/test ci-e2e-conmonrs

@openshift-merge-robot openshift-merge-robot merged commit c4a9c6d into cri-o:main Oct 28, 2022
@adrianreber adrianreber mentioned this pull request Jan 24, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrianreber @saschagrunert @openshift-merge-robot