Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pass tracer to conmon-rs client #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 17, 2023
Merged

Pass tracer to conmon-rs client #6377

openshift-merge-robot merged 1 commit into from
Jan 17, 2023

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 15, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes the span connection between the client and CRI-O.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@saschagrunert
Pass tracer to conmon-rs client
79b1b59 
This fixes the span connection between the client and CRI-O.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 15, 2022
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl November 15, 2022 11:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

Merging #6377 (79b1b59) into main (7591cff) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6377      +/-   ##
==========================================
- Coverage   43.55%   43.54%   -0.01%     
==========================================
  Files         123      123              
  Lines       14390    14391       +1     
==========================================
- Hits         6267     6266       -1     
- Misses       7441     7443       +2     
  Partials      682      682

@haircommander
Copy link
Member

haircommander commented Nov 15, 2022

/retest

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Nov 15, 2022

LGTM
assuming happy tests

@haircommander
Copy link
Member

haircommander commented Nov 17, 2022

/retest

@haircommander
Copy link
Member

haircommander commented Nov 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022
@github-actions
Copy link

github-actions bot commented Dec 18, 2022

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2022
@saschagrunert
Copy link
Member Author

saschagrunert commented Jan 17, 2023

/override ci/prow/ci-rhel-e2e
/override ci/prow/ci-cgroupv2-e2e
/override ci/prow/ci-rhel-critest
/override ci/prow/ci-crun-e2e
/override ci/prow/ci-rhel-integration
/override ci/prow/ci-cgroupv2-e2e-crun
/override ci/prow/ci-cgroupv2-e2e-features

@saschagrunert saschagrunert removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e, ci/prow/ci-cgroupv2-e2e-crun, ci/prow/ci-cgroupv2-e2e-features, ci/prow/ci-crun-e2e, ci/prow/ci-rhel-critest, ci/prow/ci-rhel-e2e, ci/prow/ci-rhel-integration

Details

In response to this:

/override ci/prow/ci-rhel-e2e
/override ci/prow/ci-cgroupv2-e2e
/override ci/prow/ci-rhel-critest
/override ci/prow/ci-crun-e2e
/override ci/prow/ci-rhel-integration
/override ci/prow/ci-cgroupv2-e2e-crun
/override ci/prow/ci-cgroupv2-e2e-features

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jan 17, 2023

/override ci/prow/ci-rhel-e2e
/override ci/prow/ci-cgroupv2-e2e
/override ci/prow/ci-rhel-critest
/override ci/prow/ci-crun-e2e
/override ci/prow/ci-rhel-integration
/override ci/prow/ci-cgroupv2-e2e-crun
/override ci/prow/ci-cgroupv2-e2e-features

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e, ci/prow/ci-cgroupv2-e2e-crun, ci/prow/ci-cgroupv2-e2e-features, ci/prow/ci-crun-e2e, ci/prow/ci-rhel-critest, ci/prow/ci-rhel-e2e, ci/prow/ci-rhel-integration

Details

In response to this:

/override ci/prow/ci-rhel-e2e
/override ci/prow/ci-cgroupv2-e2e
/override ci/prow/ci-rhel-critest
/override ci/prow/ci-crun-e2e
/override ci/prow/ci-rhel-integration
/override ci/prow/ci-cgroupv2-e2e-crun
/override ci/prow/ci-cgroupv2-e2e-features

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jan 17, 2023

/override ci/kata-jenkins

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/kata-jenkins

Details

In response to this:

/override ci/kata-jenkins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jan 17, 2023

/override ci/prow/ci-e2e-conmonrs

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-conmonrs

Details

In response to this:

/override ci/prow/ci-e2e-conmonrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2023

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/kata-jenkins 79b1b59 link unknown /test kata-containers
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@littlejawa
Copy link
Contributor

littlejawa commented Jan 17, 2023

kata-jenkins has failed on "ctr pod lifecycle with evented pleg enabled"
This is being worked on in #6531 and is unrelated to this PR.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jan 17, 2023

/override ci/kata-jenkins

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/kata-jenkins

Details

In response to this:

/override ci/kata-jenkins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit dec9b75 into cri-o:main Jan 17, 2023
@saschagrunert saschagrunert deleted the tracer branch January 17, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saschagrunert @haircommander @TomSweeneyRedHat @openshift-ci-robot @littlejawa @openshift-merge-robot