Support checkpointing infra less containers #6379

adrianreber · 2022-11-15T16:21:57Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add support to checkpoint and restore containers in pods without infrastructure containers.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added support to checkpoint and restore containers in pods without infrastructure containers.

openshift-ci · 2022-11-15T16:22:14Z

Hi @adrianreber. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2022-11-15T16:56:38Z

Codecov Report

Merging #6379 (fe24583) into main (5d04dd4) will increase coverage by 0.08%.
The diff coverage is 60.46%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6379      +/-   ##
==========================================
+ Coverage   43.58%   43.66%   +0.08%     
==========================================
  Files         123      123              
  Lines       14390    14374      -16     
==========================================
+ Hits         6272     6277       +5     
+ Misses       7438     7417      -21     
  Partials      680      680

saschagrunert

/ok-to-test

saschagrunert · 2022-11-17T08:11:02Z

/ok-to-test

adrianreber · 2022-11-17T13:48:19Z

/retest-required

haircommander · 2022-11-17T13:54:45Z

/lgtm

thanks @adrianreber I think there are some CI woes but I'll give you the tag in case they resolve themselves

adrianreber · 2022-11-17T20:11:58Z

/retest-required

adrianreber · 2022-11-17T22:43:23Z

/retest-required

adrianreber · 2022-11-18T02:39:50Z

/retest-required

saschagrunert

/retest

openshift-ci · 2022-11-18T08:14:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianreber, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adrianreber · 2022-11-18T20:24:09Z

/retest-required

adrianreber · 2022-11-21T06:58:19Z

/retest-required

adrianreber · 2022-11-21T18:35:16Z

/retest-required

haircommander · 2022-12-16T18:43:45Z

wait
/hold
log capitalization is still failing @adrianreber https://github.com/cri-o/cri-o/actions/runs/3707997205/jobs/6285066872

adrianreber · 2022-12-16T18:56:20Z

I thought I removed that line. Let me check.

adrianreber · 2022-12-16T18:59:31Z

wait /hold log capitalization is still failing @adrianreber https://github.com/cri-o/cri-o/actions/runs/3707997205/jobs/6285066872

I removed the line and force pushed.

adrianreber · 2022-12-16T19:02:38Z

It still fails. Strange.

Signed-off-by: Adrian Reber <[email protected]>

adrianreber · 2022-12-16T19:05:21Z

Finally the line is gone.

haircommander · 2022-12-16T20:26:33Z

/override ci/prow/ci-rhel-integration
/override ci/prow/ci-e2e-conmonrs

openshift-ci · 2022-12-16T20:26:41Z

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-e2e-conmonrs, ci/prow/ci-rhel-integration

Details

In response to this:

/override ci/prow/ci-rhel-integration
/override ci/prow/ci-e2e-conmonrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2022-12-16T20:26:44Z

/lgtm

haircommander · 2022-12-16T21:28:59Z

/override ci/prow/ci-e2e-conmonrs

openshift-ci · 2022-12-16T21:29:05Z

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-e2e-conmonrs

Details

In response to this:

/override ci/prow/ci-e2e-conmonrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2022-12-16T21:47:26Z

/override ci/prow/e2e-gcp-ovn
/hold cancel

openshift-ci · 2022-12-16T21:47:33Z

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2022-12-19T16:51:06Z

/override ci/prow/ci-rhel-integration
/override ci/prow/ci-e2e-conmonrs

openshift-ci · 2022-12-19T16:51:13Z

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-e2e-conmonrs, ci/prow/ci-rhel-integration

Details

In response to this:

/override ci/prow/ci-rhel-integration
/override ci/prow/ci-e2e-conmonrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2022-12-19T20:30:13Z

/override ci/prow/e2e-gcp-ovn

openshift-ci · 2022-12-19T20:30:19Z

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2022-12-19T20:40:27Z

/test ci-fedora-integration

haircommander · 2022-12-19T20:51:49Z

/override ci/prow/ci-rhel-integration

openshift-ci · 2022-12-19T20:51:55Z

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-rhel-integration

Details

In response to this:

/override ci/prow/ci-rhel-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adrianreber requested review from fidencio and mrunalp as code owners November 15, 2022 16:21

openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 15, 2022

openshift-ci bot requested review from QiWang19 and wgahnagl November 15, 2022 16:22

openshift-ci bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2022

adrianreber force-pushed the 2022-11-15-infra-less branch 2 times, most recently from df5046a to bd53ed1 Compare November 15, 2022 16:37

saschagrunert approved these changes Nov 17, 2022

View reviewed changes

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2022

openshift-ci bot assigned haircommander Nov 17, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022

saschagrunert approved these changes Nov 18, 2022

View reviewed changes

openshift-ci bot assigned saschagrunert Nov 18, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2022

adrianreber force-pushed the 2022-11-15-infra-less branch from 6566497 to b8bff42 Compare December 16, 2022 18:59

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022

adrianreber added 2 commits December 16, 2022 19:04

Support checkpointing infra less containers

da96d6b

Signed-off-by: Adrian Reber <[email protected]>

ci: make golangci-lint happy

fe24583

Signed-off-by: Adrian Reber <[email protected]>

adrianreber force-pushed the 2022-11-15-infra-less branch from b8bff42 to fe24583 Compare December 16, 2022 19:04

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2022

openshift-merge-robot merged commit a0508c2 into cri-o:main Dec 19, 2022

adrianreber mentioned this pull request Jan 24, 2023

REQUEST: New organization membership for adrianreber #6562

Closed

4 tasks

kwilczynski mentioned this pull request Dec 3, 2024

[release-1.25] OCPBUGS-45905: Only restore container if all bind mounts are defined #8814

Closed

Support checkpointing infra less containers #6379

Support checkpointing infra less containers #6379

Uh oh!

Conversation

adrianreber commented Nov 15, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci bot commented Nov 15, 2022

Uh oh!

codecov bot commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

saschagrunert commented Nov 17, 2022

Uh oh!

adrianreber commented Nov 17, 2022

Uh oh!

haircommander commented Nov 17, 2022

Uh oh!

adrianreber commented Nov 17, 2022

Uh oh!

adrianreber commented Nov 17, 2022

Uh oh!

adrianreber commented Nov 18, 2022

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 18, 2022

Uh oh!

adrianreber commented Nov 18, 2022

Uh oh!

adrianreber commented Nov 21, 2022

Uh oh!

adrianreber commented Nov 21, 2022

Uh oh!

haircommander commented Dec 16, 2022

Uh oh!

adrianreber commented Dec 16, 2022

Uh oh!

adrianreber commented Dec 16, 2022

Uh oh!

adrianreber commented Dec 16, 2022

Uh oh!

adrianreber commented Dec 16, 2022

Uh oh!

haircommander commented Dec 16, 2022

Uh oh!

openshift-ci bot commented Dec 16, 2022

Uh oh!

haircommander commented Dec 16, 2022

Uh oh!

haircommander commented Dec 16, 2022

Uh oh!

openshift-ci bot commented Dec 16, 2022

Uh oh!

haircommander commented Dec 16, 2022

Uh oh!

openshift-ci bot commented Dec 16, 2022

Uh oh!

haircommander commented Dec 19, 2022

Uh oh!

openshift-ci bot commented Dec 19, 2022

Uh oh!

haircommander commented Dec 19, 2022

Uh oh!

openshift-ci bot commented Dec 19, 2022

Uh oh!

haircommander commented Dec 19, 2022

Uh oh!

haircommander commented Dec 19, 2022

Uh oh!

openshift-ci bot commented Dec 19, 2022

codecov bot commented Nov 15, 2022 •

edited

Loading