Use containerd v1.7.0-beta.0 #6381
Conversation
|
Hi @littlejawa. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6381 +/- ##
=======================================
Coverage 43.57% 43.57%
=======================================
Files 123 123
Lines 14390 14390
=======================================
+ Hits 6270 6271 +1
Misses 7439 7439
+ Partials 681 680 -1 |
c6c4bf6 to
34b1185
Compare
|
/ok-to-test |
|
/lgtm I don't think CI issues are related |
fidencio
left a comment
There was a problem hiding this comment.
lgtm, thanks @littlejawa!
|
@haircommander - it seems I can't set the milestone here, but this is the PR that I think should be part of 1.26 |
|
@littlejawa can you rebase to get the ci fixes |
This version of containerd has removed the dependency on gogo/protobuf from the shim v2 interface. Signed-off-by: Julien Ropé <[email protected]>
34b1185 to
1b42a3d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fidencio, littlejawa, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-rhel-integration DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/ci-rhel-integration |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-rhel-integration DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
containerd has released a new version v1.7.0-beta.0, where the gogo/protobuf dependency was removed.
I have tried it with cri-o, and it seems to be working as expected.
This is still a beta release though, so we have to be cautious in using it. But at least, it shows that the next release of containerd should fix our problem.
If accepted, this replaces the PR #6371
Which issue(s) this PR fixes:
Fixes #6350
Does this PR introduce a user-facing change?