Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.23] misc test fixes #6323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Oct 19, 2022
Merged

[1.23] misc test fixes #6323

openshift-merge-robot merged 3 commits into from
Oct 19, 2022

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Oct 18, 2022

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 18, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2022
@openshift-ci openshift-ci bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 18, 2022
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub October 18, 2022 20:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@haircommander haircommander changed the base branch from main to release-1.23 October 18, 2022 20:19
@haircommander haircommander requested a review from runcom as a code owner October 18, 2022 20:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-images d2a45f5 link true /test ci-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

saschagrunert and others added 2 commits October 18, 2022 16:22
@saschagrunert @haircommander
Fix unit tests
44a9256 
Commit f032cf6 introduced a change
which requires an additional fix to the unit tests to make them succeed

Signed-off-by: Sascha Grunert <[email protected]>
@rphillips @haircommander
migrate image_list to quay.io
0f31d98 
Signed-off-by: Ryan Phillips <[email protected]>
Signed-off-by: Peter Hunt~ <[email protected]>
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 18, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2022
@haircommander haircommander mentioned this pull request Oct 18, 2022
Merged
@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Merging #6323 (ff214ff) into release-1.23 (5fe1720) will increase coverage by 0.07%.
The diff coverage is 39.37%.

❗ Current head ff214ff differs from pull request most recent head bdc6cdd. Consider uploading reports for the commit bdc6cdd to get more accurate results

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.23    #6323      +/-   ##
================================================
+ Coverage         42.92%   42.99%   +0.07%     
================================================
  Files               123      123              
  Lines             12315    12399      +84     
================================================
+ Hits               5286     5331      +45     
- Misses             6522     6559      +37     
- Partials            507      509       +2

@saschagrunert @haircommander
Fix nginx based integration tests
bdc6cdd 
The image digest is gone from the upstream remote so we now point to the
latest version of it.

Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
saschagrunert approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 724e932 into cri-o:release-1.23 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@fidencio fidencio Awaiting requested review from fidencio

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@runcom runcom Awaiting requested review from runcom runcom is a code owner

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haircommander @saschagrunert @openshift-merge-robot @rphillips