Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Correctly extend $PATH before calling conmon during restore #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 26, 2022
Merged

Correctly extend $PATH before calling conmon during restore #6338

openshift-merge-robot merged 1 commit into from
Oct 26, 2022
+1 −1

Conversation

@adrianreber
Copy link
Member

@adrianreber adrianreber commented Oct 25, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

The way I extended the PATH when calling conmon during restore was just wrong. This fixes the wrong PATH.

Which issue(s) this PR fixes:

Fixes: #6337

Does this PR introduce a user-facing change?

None

@adrianreber adrianreber requested a review from mrunalp as a code owner October 25, 2022 12:19
@openshift-ci openshift-ci bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 25, 2022
@adrianreber adrianreber mentioned this pull request Oct 25, 2022
Closed
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 25, 2022
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub October 25, 2022 12:22
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

Hi @adrianreber. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saschagrunert
saschagrunert approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianreber, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #6338 (658a115) into main (1e6fd9c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6338   +/-   ##
=======================================
  Coverage   44.21%   44.21%           
=======================================
  Files         122      122           
  Lines       13862    13862           
=======================================
  Hits         6129     6129           
  Misses       7061     7061           
  Partials      672      672

@adrianreber
Copy link
Member Author

adrianreber commented Oct 25, 2022

/retest-required

1 similar comment
@adrianreber
Copy link
Member Author

adrianreber commented Oct 26, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 94080cf into cri-o:main Oct 26, 2022
@adrianreber adrianreber mentioned this pull request Jan 24, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cri-o assumes criu binary is in /usr/sbin/criu

3 participants

@adrianreber @saschagrunert @openshift-merge-robot