Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.23] crio storage wipe backport #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wgahnagl wants to merge 2 commits into from
Closed

[1.23] crio storage wipe backport #6448

wgahnagl wants to merge 2 commits into from

Conversation

@wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Dec 13, 2022 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

cherry-pick of #6022

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/OCPBUGS-3708

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update `version-file-persist` to be empty by default, and do not wipe images when it is so.

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval by writing /assign @haircommander in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 13, 2022
@haircommander
Copy link
Member

haircommander commented Dec 13, 2022

/hold

for #6449

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #6448 (fa6ea73) into release-1.23 (a6a1e6e) will increase coverage by 0.01%.
The diff coverage is 85.71%.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.23    #6448      +/-   ##
================================================
+ Coverage         42.98%   42.99%   +0.01%     
================================================
  Files               123      123              
  Lines             12399    12398       -1     
================================================
+ Hits               5330     5331       +1     
+ Misses             6560     6557       -3     
- Partials            509      510       +1

@sohankunkerkar
Copy link
Member

sohankunkerkar commented Dec 19, 2022

/retest

@github-actions
Copy link

github-actions bot commented Jan 19, 2023

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2023
@jrvaldes
Copy link
Contributor

jrvaldes commented Feb 6, 2023 •
edited
Loading

/close

to leverage #6608

cc @haircommander

@openshift-ci openshift-ci bot closed this Feb 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

@jrvaldes: Closed this PR.

Details

In response to this:

/close

to leverage #6608

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

@haircommander haircommander Awaiting requested review from haircommander

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wgahnagl @haircommander @sohankunkerkar @jrvaldes