[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval by writing /assign @giuseppe in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

docs and completions validation still need love

Codecov Report

Merging #6449 (3aed67c) into release-1.24 (c4567c0) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@               Coverage Diff                @@
##           release-1.24    #6449      +/-   ##
================================================
+ Coverage         42.86%   42.88%   +0.01%     
================================================
  Files               124      124              
  Lines             12741    12740       -1     
================================================
+ Hits               5462     5463       +1     
+ Misses             6753     6750       -3     
- Partials            526      527       +1     

docs and completions validation still need love

@haircommander validate-completions job failed with:

rm: cannot remove '/etc/containers/storage.conf': No such file or directory

This was changed for main branch by #4503. Missing a backport maybe? cc @wgahnagl

/test ?

@jrvaldes: The following commands are available to trigger required jobs:

• /test e2e-agnostic
• /test e2e-gcp
• /test images

Use /test all to run all jobs.

/test ?

to rerun the prow tests, you'd use /retest
to rerun the gh actions tests, you need to click Details and then rerun failed jobs at the top right

hm, when I run
git diff upstream/release-1.24..upstream/main -- .github/workflows/test.yml
I get

-      - run: |
-          chmod -R +x bin
-          sudo rm /etc/containers/storage.conf
+      - run: chmod -R +x bin

I am having trouble finding the commit that we removed that line, but that would help

#4503.

See #6449 (comment)

🙃 sorry I missed you mentioned it! that one is already a part of 1.21 and later (see a0568ac) so it's a Pr that came later

upside_down_face sorry I missed you mentioned it! that one is already a part of 1.21 and later (see a0568ac) so it's a Pr that came later

@haircommander, This PR removed the above-mentioned line

• Fix GitHub actions CI #6392

nice find! @jrvaldes would you like to initiate the cherry-pick process of that one? It looks like it's in 1.26 already, so we can begin with 1.25, and pull it back down (one-by-one merging in reverse order of age)

nice find! @jrvaldes would you like to initiate the cherry-pick process of that one? It looks like it's in 1.26 already, so we can begin with 1.25, and pull it back down (one-by-one merging in reverse order of age)

@haircommander PR #6392 includes several adjustments (that may not be related to the missing changes) is it safe to backport them all? Should they be analyzed individually? If so, a manual cherry-pick may be required.

nice find! @jrvaldes would you like to initiate the cherry-pick process of that one? It looks like it's in 1.26 already, so we can begin with 1.25, and pull it back down (one-by-one merging in reverse order of age)

@haircommander PR #6392 includes several adjustments (that may not be related to the missing changes) is it safe to backport them all? Should they be analyzed individually? If so, a manual cherry-pick may be required.

How about you manually backport to 1.25 and find the pieces needed to fix that. If they all seem like they will improve the situation in 1.24 and earlier, we can automatically backport there, and we can add more/remove some manually if needed

@haircommander

nice find! @jrvaldes would you like to initiate the cherry-pick process of that one? It looks like it's in 1.26 already, so we can begin with 1.25, and pull it back down (one-by-one merging in reverse order of age)

@haircommander , I asked the bot for help with an automatic cherry-pick.

• [release-1.25] Fix GitHub actions CI #6505

nice find! @jrvaldes would you like to initiate the cherry-pick process of that one? It looks like it's in 1.26 already, so we can begin with 1.25, and pull it back down (one-by-one merging in reverse order of age)

@haircommander PR #6392 includes several adjustments (that may not be related to the missing changes) is it safe to backport them all? Should they be analyzed individually? If so, a manual cherry-pick may be required.

How about you manually backport to 1.25 and find the pieces needed to fix that. If they all seem like they will improve the situation in 1.24 and earlier, we can automatically backport there, and we can add more/remove some manually if needed

Agree. Will open specific manual backports in case there are conflicts.

/hold

Depends on:

• [release-1.24] Fix GitHub actions CI #6506

/hold cancel

#6506 merged.

/close

in favor of #6509

@jrvaldes: Closed this PR.