OCPNODE-1336: Enable upstream CI to test node e2e with evented pleg feature #6489
Conversation
|
Hi @sairameshv. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d621289 to
dd552e2
Compare
|
/cc @harche |
scripts/node_e2e_installer
Outdated
|
|
||
| for condition in "true" "True" "TRUE"; do | ||
| if [[ "${ENABLE_POD_EVENTS}" = "$condition" ]]; then | ||
| echo "ENABLE_POD_EVENTS=true" >>/etc/sysconfig/crio |
There was a problem hiding this comment.
this likely is a follow up because I see some other examples, but I think we should use drop-in files instead of env variables in sysconfig files, as I would say it's a preferred method of configuring cri-o
This code change helps in enabling the evented pleg feature in cri-o while running the CI(node e2e tests) jobs in the upstream k8s/test-infra Signed-off-by: Sai Ramesh Vanka <[email protected]>
dd552e2 to
815a426
Compare
|
/ok-to-test |
|
/retest |
|
/test kata-containers |
|
@sairameshv: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/ci-rhel-integration |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, sairameshv The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/kata-jenkins, ci/prow/ci-rhel-integration DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Sai Ramesh Vanka [email protected]
What type of PR is this?
/kind ci
What this PR does / why we need it:
This code change helps in enabling the evented pleg feature in cri-o while running the CI(node e2e tests) jobs in the upstream k8s/test-infra
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?