Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.22] Backport crio storage wipe #6420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wgahnagl wants to merge 2 commits into from
Closed

[1.22] Backport crio storage wipe #6420

wgahnagl wants to merge 2 commits into from

Conversation

@wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Dec 2, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

cherry-pick of #6022

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/OCPBUGS-3708

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update `version-file-persist` to be empty by default, and do not wipe images when it is so.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 2, 2022
@openshift-ci openshift-ci bot requested a review from nalind December 2, 2022 14:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval by writing /assign @giuseppe in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wgahnagl wgahnagl force-pushed the backport-crio-storage-wipe branch 3 times, most recently from c7fe9f9 to 9d25aaa Compare December 2, 2022 15:18
@wgahnagl wgahnagl force-pushed the backport-crio-storage-wipe branch from 9d25aaa to 851176c Compare December 2, 2022 15:22
@haircommander
Copy link
Member

haircommander commented Dec 8, 2022

I think you need to run make docs-generation completions

@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 9, 2022
@wgahnagl wgahnagl force-pushed the backport-crio-storage-wipe branch from f1b55ff to 79a2a07 Compare December 9, 2022 16:14
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Dec 9, 2022
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Dec 9, 2022

/retest

1 similar comment
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Dec 12, 2022

/retest

@wgahnagl wgahnagl force-pushed the backport-crio-storage-wipe branch from 79a2a07 to 7f29fb1 Compare December 12, 2022 21:27
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Dec 13, 2022

/retest

@github-actions
Copy link

github-actions bot commented Jan 13, 2023

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2023
@jrvaldes
Copy link
Contributor

jrvaldes commented Jan 19, 2023

@cri-o/cri-o-maintainers As a follow-up for #6544 (comment), does it makes sense to close this PR as 1.22 is out of support ?

@haircommander
Copy link
Member

haircommander commented Jan 19, 2023

we still have downstream obligations that motivate this change. We just probably won't package it upstream

@jrvaldes
Copy link
Contributor

jrvaldes commented Feb 6, 2023

/close

to leverage #6612

@openshift-ci openshift-ci bot closed this Feb 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

@jrvaldes: Closed this PR.

Details

In response to this:

/close

to leverage #6612

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@nalind nalind Awaiting requested review from nalind

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wgahnagl @haircommander @jrvaldes