[release-1.24] Fix GitHub actions CI #6506

jrvaldes · 2023-01-10T02:19:36Z

This is a manual cherry-pick of #6505

None

openshift-ci · 2023-01-10T02:19:41Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2023-01-10T02:29:03Z

Codecov Report

Merging #6506 (484e267) into release-1.24 (ae53655) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@              Coverage Diff              @@
##           release-1.24    #6506   +/-   ##
=============================================
  Coverage         42.91%   42.92%           
=============================================
  Files               124      124           
  Lines             12741    12741           
=============================================
+ Hits               5468     5469    +1     
+ Misses             6749     6748    -1     
  Partials            524      524

sonatype-lift · 2023-01-10T02:30:27Z

internal/factory/container/container.go


 // SpecAddMount adds a specified mount to the spec
+//
+//nolint:gocritic // passing the spec mount around here is intentional


nolintlint: directive //nolint:gocritic // passing the spec mount around here is intentional is unused for linter "gocritic"

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@cri-o/cri-o-maintainers I may need directions here; Is this required in release-1.24? sonatype-lift bot did not complain in 1.25 or 1.26 PRs.

it's possible we'd not enabled the gocritic linter here

Removed the unused linter instructions in 484e267

openshift-ci-robot · 2023-01-10T13:57:28Z

@jrvaldes: This pull request references Jira Issue OCPBUGS-3708, which is invalid:

expected Jira Issue OCPBUGS-3708 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #6505

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-10T13:58:55Z

@jrvaldes: No Jira bug is referenced in the title of this pull request.
To reference a bug, add 'OCPBUGS-XXX:' to the title of this pull request and request another bug refresh with /jira refresh.

Details

In response to this:

This is a manual cherry-pick of #6505

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Sascha Grunert <[email protected]> (cherry picked from commit 51d3621)

haircommander · 2023-01-10T16:56:45Z

/approve

LGTM, thanks!

openshift-ci · 2023-01-10T16:56:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, jrvaldes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2023-01-10T17:20:16Z

/lgtm

jrvaldes · 2023-01-10T18:45:27Z

Set release-note as None in the PR description as per release note process

jrvaldes · 2023-01-11T13:37:14Z

/cherry-pick release-1.23

openshift-cherrypick-robot · 2023-01-11T13:38:05Z

@jrvaldes: #6506 failed to apply on top of branch "release-1.23":

Applying: Fix GitHub actions CI
Using index info to reconstruct a base tree...
M	.github/workflows/test.yml
M	.github/workflows/verify.yml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/verify.yml
CONFLICT (content): Merge conflict in .github/workflows/verify.yml
Auto-merging .github/workflows/test.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix GitHub actions CI
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2023

openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 10, 2023

sonatype-lift bot reviewed Jan 10, 2023

View reviewed changes

jrvaldes changed the title ~~[release-1.24] Fix GitHub actions CI~~ [release-1.24] OCPBUGS-3708: Fix GitHub actions CI Jan 10, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 10, 2023

jrvaldes changed the title ~~[release-1.24] OCPBUGS-3708: Fix GitHub actions CI~~ [release-1.24] Fix GitHub actions CI Jan 10, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 10, 2023

jrvaldes force-pushed the cherry-pick-6392-to-release-1.24 branch from 07a619c to 3a1fa33 Compare January 10, 2023 15:13

Fix GitHub actions CI

484e267

Signed-off-by: Sascha Grunert <[email protected]> (cherry picked from commit 51d3621)

jrvaldes force-pushed the cherry-pick-6392-to-release-1.24 branch from 3a1fa33 to 484e267 Compare January 10, 2023 15:14

jrvaldes marked this pull request as ready for review January 10, 2023 15:15

jrvaldes requested review from mrunalp and runcom as code owners January 10, 2023 15:15

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2023

jrvaldes requested a review from haircommander January 10, 2023 15:16

openshift-ci bot requested review from QiWang19 and klihub January 10, 2023 15:16

jrvaldes mentioned this pull request Jan 10, 2023

[1.24] crio storage wipe backport #6449

Closed

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023

openshift-ci bot assigned haircommander Jan 10, 2023

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 10, 2023

openshift-ci bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 10, 2023

openshift-merge-robot merged commit 1d7361a into cri-o:release-1.24 Jan 10, 2023

jrvaldes mentioned this pull request Jan 11, 2023

[release-1.23] Fix GitHub actions CI #6521

Merged

This was referenced Oct 22, 2023

[release-1.24] OCPBUGS-20596: build(deps): bump google.golang.org/grpc from 1.43.0 to 1.58.3 #7421

Merged

[release-1.24] OCPBUGS-20596: build(deps): bump golang.org/x/net from 0.0.0-20220225172249-27dd8689420f to 0.17.0 #7422

Merged

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

[release-1.24] Fix GitHub actions CI #6506

[release-1.24] Fix GitHub actions CI #6506

Uh oh!

Conversation

jrvaldes commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jan 10, 2023

Uh oh!

codecov bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonatype-lift bot Jan 10, 2023

Choose a reason for hiding this comment

Uh oh!

jrvaldes Jan 10, 2023

Choose a reason for hiding this comment

Uh oh!

haircommander Jan 10, 2023

Choose a reason for hiding this comment

Uh oh!

jrvaldes Jan 10, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 10, 2023

Uh oh!

openshift-ci-robot commented Jan 10, 2023

Uh oh!

haircommander commented Jan 10, 2023

Uh oh!

openshift-ci bot commented Jan 10, 2023

Uh oh!

haircommander commented Jan 10, 2023

Uh oh!

jrvaldes commented Jan 10, 2023

Uh oh!

jrvaldes commented Jan 11, 2023

Uh oh!

openshift-cherrypick-robot commented Jan 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jrvaldes commented Jan 10, 2023 •

edited

Loading

codecov bot commented Jan 10, 2023 •

edited

Loading