Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.24] Update crio docs #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jrvaldes wants to merge 1 commit into from
Closed

[release-1.24] Update crio docs #6510

jrvaldes wants to merge 1 commit into from

Conversation

@jrvaldes
Copy link
Contributor

@jrvaldes jrvaldes commented Jan 10, 2023

Ran:

  make docs-generation

None

@jrvaldes
docs: Update crio docs
8bb7288 
Ran:
```
  make docs-generation
```

Signed-off-by: Jose Valdes <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
Once this PR has been reviewed and has the lgtm label, please assign kolyshkin for approval by writing /assign @kolyshkin in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes jrvaldes mentioned this pull request Jan 10, 2023
Merged
@haircommander
Copy link
Member

haircommander commented Jan 10, 2023

it looks like you didn't compile the crio binary before running on 1.24, as it's showing options in main but not in 1.24.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #6510 (8bb7288) into release-1.24 (1d7361a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.24    #6510   +/-   ##
=============================================
  Coverage         42.91%   42.91%           
=============================================
  Files               124      124           
  Lines             12741    12741           
=============================================
  Hits               5468     5468           
  Misses             6749     6749           
  Partials            524      524

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 10, 2023

/close

@openshift-ci openshift-ci bot closed this Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@jrvaldes: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp will be requested when the pull request is marked ready for review mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom will be requested when the pull request is marked ready for review runcom is a code owner

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrvaldes @haircommander