Thanks to visit codestin.com
Credit goes to github.com

Skip to content

contrib: run systemd service with full permissions for cgroupv2 #6970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sohankunkerkar wants to merge 1 commit into from
Closed

contrib: run systemd service with full permissions for cgroupv2 #6970

sohankunkerkar wants to merge 1 commit into from

Conversation

@sohankunkerkar
Copy link
Member

@sohankunkerkar sohankunkerkar commented May 25, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow cri-o.service to run with full privileges on a system with cgroupv2 enabled

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 25, 2023
@sohankunkerkar sohankunkerkar mentioned this pull request May 25, 2023
Closed
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited
Loading

Codecov Report

Merging #6970 (80b65e2) into main (e0769d1) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6970   +/-   ##
=======================================
  Coverage   49.21%   49.22%           
=======================================
  Files         132      132           
  Lines       15381    15381           
=======================================
+ Hits         7570     7571    +1     
+ Misses       6909     6908    -1     
  Partials      902      902

haircommander
haircommander reviewed May 25, 2023
View reviewed changes
@haircommander haircommander marked this pull request as ready for review May 25, 2023 19:20
@haircommander haircommander requested a review from mrunalp as a code owner May 25, 2023 19:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2023
@haircommander
Copy link
Member

haircommander commented May 25, 2023

LGTM

/approve

moved from draft to see how the tests feel

@openshift-ci openshift-ci bot requested review from klihub and wgahnagl May 25, 2023 19:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@sohankunkerkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-cgroupv2-e2e-crun 80b65e2 link true /test ci-cgroupv2-e2e-crun
ci/prow/ci-crun-e2e 80b65e2 link true /test ci-crun-e2e
ci/prow/ci-e2e 80b65e2 link true /test ci-e2e
ci/prow/ci-e2e-evented-pleg 80b65e2 link true /test ci-e2e-evented-pleg
ci/prow/ci-cgroupv2-e2e 80b65e2 link true /test ci-cgroupv2-e2e
ci/prow/ci-e2e-conmonrs 80b65e2 link true /test ci-e2e-conmonrs
ci/prow/ci-rhel-e2e 80b65e2 link true /test ci-rhel-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Jun 2, 2023

LGTM once the tests get happy

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Closing this PR since it had no activity in the past 90 days.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 1, 2023
@github-actions github-actions bot closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sohankunkerkar @haircommander @TomSweeneyRedHat