OCPBUGS-11291: skip when ListImage with filter image hasn't done pulling #7184
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: QiWang19 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@QiWang19: This pull request references Jira Issue OCPBUGS-11291, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
internal/storage/image.go
Outdated
| donePulling := true | ||
| for _, name := range image.Names { | ||
| if _, ok := ImageBeingPulled.Load(name); ok { | ||
| donePulling = false |
There was a problem hiding this comment.
we can just return false here, and return true below, no need for donePulling if we separate the functions
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7184 +/- ##
==========================================
- Coverage 49.22% 49.21% -0.02%
==========================================
Files 136 136
Lines 15485 15488 +3
==========================================
- Hits 7623 7622 -1
- Misses 6960 6963 +3
- Partials 902 903 +1 |
Apply fix cri-o#4726 when ListImage with `filter`. Previous bug https://bugzilla.redhat.com/show_bug.cgi?id=1942608 appeared in the log hyperkube ListImages with filters. `"ListImages with filter from image service failed" err="rpc error: code = Unknown desc = error locating item named \"manifest\" for image with ID \"9e11cc7364c9791ebf68949c852bf121cb4ae5829c925a1da6546be6f63b3536\": file does not exist" filter="nil"` Signed-off-by: Qi Wang <[email protected]>
ba69277 to
05419b8
Compare
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I don't think this PR makes sense for the bug. |
|
@QiWang19: This pull request references Jira Issue OCPBUGS-11291. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Apply a previous fix #4726 to ListImage with
filter.If the file not found error was caused by image not done pulling when ListImages() with filter, skip the image and the error.
Previous bug https://bugzilla.redhat.com/show_bug.cgi?id=1942608 appeared in https://issues.redhat.com/browse/OCPBUGS-11291.
The log hyperkube ListImages with filters.
"ListImages with filter from image service failed" err="rpc error: code = Unknown desc = error locating item named \"manifest\" for image with ID \"9e11cc7364c9791ebf68949c852bf121cb4ae5829c925a1da6546be6f63b3536\": file does not exist" filter="nil"Which issue(s) this PR fixes:
https://issues.redhat.com/browse/OCPBUGS-11291
Special notes for your reviewer:
Does this PR introduce a user-facing change?