Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build-static: misc fixes needed for 1.25.4 generation #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 9, 2023
Merged

build-static: misc fixes needed for 1.25.4 generation #7189

openshift-merge-robot merged 1 commit into from
Aug 9, 2023

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Aug 3, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

I had trouble building the binaries--I needed to use host network and change the URL

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #7189 (8937245) into main (bdb1c61) will increase coverage by 0.01%.
Report is 17 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7189      +/-   ##
==========================================
+ Coverage   49.23%   49.24%   +0.01%     
==========================================
  Files         136      136              
  Lines       15494    15494              
==========================================
+ Hits         7628     7630       +2     
+ Misses       6963     6962       -1     
+ Partials      903      902       -1

@haircommander haircommander marked this pull request as ready for review August 8, 2023 15:30
@haircommander haircommander requested a review from mrunalp as a code owner August 8, 2023 15:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2023
@haircommander haircommander added this to the 1.28 milestone Aug 8, 2023
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl August 8, 2023 15:30
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

saschagrunert commented Aug 9, 2023

/test e2e-aws-ovn

@saschagrunert
Copy link
Member

saschagrunert commented Aug 9, 2023

/test ci-e2e-conmonrs

@openshift-merge-robot openshift-merge-robot merged commit 29bc547 into cri-o:main Aug 9, 2023
@haircommander
Copy link
Member Author

haircommander commented Aug 9, 2023

/cherry-pick release-1.27

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 9, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 9, 2023

@haircommander: new pull request created: #7198

Details

In response to this:

/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

1.28

Development

Successfully merging this pull request may close these issues.

4 participants

@haircommander @saschagrunert @openshift-cherrypick-robot @openshift-merge-robot