checkpoint: clean-up checkpoint dir after export #7355
Conversation
|
Hi @rst0git. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Sounds right. Thanks. |
|
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7355 +/- ##
==========================================
- Coverage 49.19% 49.18% -0.01%
==========================================
Files 145 145
Lines 15818 15821 +3
==========================================
Hits 7782 7782
- Misses 7099 7101 +2
- Partials 937 938 +1 |
|
/retest |
|
/retest |
|
/approve |
|
/retest |
1 similar comment
|
/retest |
|
A friendly reminder that this PR had no activity for 30 days. |
The CRI-O implementation for container checkpointing is based on Podman. One of the differences between CRI-O and Podman is that with CRI-O, containers continue to run after checkpointing, and the checkpoint is exported as a tar archive file. However, after the checkpoint has been created, all checkpoint files remain in the userdata directory of the container. As a result, subsequent checkpoints include files from previous checkpoints. To fix this problem, this patch ensures that we clean up the checkpoint directory after the checkpoint files have been exported. Suggested-by: Adrian Reber <[email protected]> Signed-off-by: Radostin Stoyanov <[email protected]>
3d77ed5 to
1cea76d
Compare
|
@mrunalp PTAL |
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, rst0git, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/override ci/prow/ci-fedora-integration |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-integration DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The CRI-O implementation for container checkpointing is based on Podman. One of the differences between CRI-O and Podman is that with CRI-O, containers continue to run after checkpointing, and the checkpoint is exported as a tar archive file. However, after the checkpoint has been created, all checkpoint files remain in the userdata directory of the container. As a result, subsequent checkpoints include files from previous checkpoints. To fix this problem, this patch ensures that we clean up the checkpoint directory after the checkpoint files have been exported.
Special notes for your reviewer:
The original pull request introducing container checkpoint (#4199) contains more information about exporting of checkpoints.
Does this PR introduce a user-facing change?