Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.27] OCPBUGS-22128: build(deps): bump google.golang.org/grpc from 1.54.0 to 1.58.3 #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kwilczynski wants to merge 1 commit into from
Closed

[release-1.27] OCPBUGS-22128: build(deps): bump google.golang.org/grpc from 1.54.0 to 1.58.3 #7384

kwilczynski wants to merge 1 commit into from

Conversation

@kwilczynski
Copy link
Contributor

@kwilczynski kwilczynski commented Oct 16, 2023 •
edited
Loading

This is a manual cherry-pick of #7366

/kind dependency-change
/assign kwilczynski

Update the google.golang.org/grpc package from 1.54.0 to 1.58.3 to fix vulnerabilities CVE-2023-39325 and CVE-2023-4448.

@kwilczynski kwilczynski requested a review from mrunalp as a code owner October 16, 2023 13:30
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Oct 16, 2023
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub October 16, 2023 13:30
saschagrunert
saschagrunert approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

for release-1.28: #7381

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 16, 2023
@kwilczynski kwilczynski changed the title [release-1.27] build(deps): bump google.golang.org/grpc from 1.58.0 to 1.58.3 [release-1.27] build(deps): bump google.golang.org/grpc from 1.54.0 to 1.58.3 Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #7384 (12af534) into release-1.27 (3fecb83) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.27    #7384   +/-   ##
=============================================
  Coverage         49.31%   49.31%           
=============================================
  Files               128      128           
  Lines             15185    15185           
=============================================
  Hits               7488     7488           
  Misses             6799     6799           
  Partials            898      898

@saschagrunert
Copy link
Member

saschagrunert commented Oct 17, 2023

/lgtm

@kwilczynski feel free to lift the hold once QA verified that everything is fixed on 1.28.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

New changes are detected. LGTM label has been removed.

@kwilczynski
Copy link
Contributor Author

kwilczynski commented Oct 18, 2023

/retest

@dependabot
build(deps): bump google.golang.org/grpc from 1.54.0 to 1.58.3
12af534 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.58.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.54.0...v1.58.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Oct 18, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski kwilczynski changed the title [release-1.27] build(deps): bump google.golang.org/grpc from 1.54.0 to 1.58.3 [release-1.27] OCPBUGS-22128: build(deps): bump google.golang.org/grpc from 1.54.0 to 1.58.3 Oct 19, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2023

@kwilczynski: This pull request references Jira Issue OCPBUGS-22128, which is invalid:

  • expected Jira Issue OCPBUGS-22128 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #7366

/kind dependency-change
/assign kwilczynski

Update the google.golang.org/grpc package from 1.54.0 to 1.58.3 to fix vulnerabilities CVE-2023-39325 and CVE-2023-4448.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski
Copy link
Contributor Author

kwilczynski commented Oct 19, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2023

@kwilczynski: This pull request references Jira Issue OCPBUGS-22128, which is invalid:

  • expected Jira Issue OCPBUGS-22128 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski
Copy link
Contributor Author

kwilczynski commented Oct 19, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2023

@kwilczynski: This pull request references Jira Issue OCPBUGS-22128, which is invalid:

  • expected Jira Issue OCPBUGS-22128 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski
Copy link
Contributor Author

kwilczynski commented Oct 20, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2023

@kwilczynski: This pull request references Jira Issue OCPBUGS-22128, which is invalid:

  • expected Jira Issue OCPBUGS-22128 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski kwilczynski closed this by deleting the head repository Oct 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2023

@kwilczynski: This pull request references Jira Issue OCPBUGS-22128. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #7366

/kind dependency-change
/assign kwilczynski

Update the google.golang.org/grpc package from 1.54.0 to 1.58.3 to fix vulnerabilities CVE-2023-39325 and CVE-2023-4448.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski
Copy link
Contributor Author

kwilczynski commented Oct 22, 2023

Reopened at #7415.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/dependency-change Categorizes issue or PR as related to changing dependencies release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kwilczynski @saschagrunert @openshift-ci-robot