Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.26] OCPBUGS-20598: build(deps): bump google.golang.org/grpc from 1.51.0 to 1.58.3 #7417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 14, 2023
Merged

[release-1.26] OCPBUGS-20598: build(deps): bump google.golang.org/grpc from 1.51.0 to 1.58.3 #7417

openshift-merge-bot merged 1 commit into from
Nov 14, 2023

Conversation

@kwilczynski
Copy link
Contributor

@kwilczynski kwilczynski commented Oct 22, 2023

This is a manual cherry-pick of #7366

/kind dependency-change
/assign kwilczynski

Update the google.golang.org/grpc package from 1.51.0 to 1.58.3 to fix vulnerabilities CVE-2023-39325 and CVE-2023-4448.

@kwilczynski kwilczynski requested a review from mrunalp as a code owner October 22, 2023 03:12
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 22, 2023
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl October 22, 2023 03:13
@kwilczynski kwilczynski changed the title build(deps): bump google.golang.org/grpc from 1.51.0 to 1.58.3 [release-1.26] OCPBUGS-20598: build(deps): bump google.golang.org/grpc from 1.51.0 to 1.58.3 Oct 22, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2023

@kwilczynski: This pull request references Jira Issue OCPBUGS-20598, which is invalid:

  • expected Jira Issue OCPBUGS-20598 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #7366

/kind dependency-change
/assign kwilczynski

Update the google.golang.org/grpc package from 1.51.0 to 1.58.3 to fix vulnerabilities CVE-2023-39325 and CVE-2023-4448.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 22, 2023
@kwilczynski kwilczynski mentioned this pull request Oct 22, 2023
Closed
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Oct 22, 2023

/approve

@kwilczynski kwilczynski force-pushed the feature/cherry-pick-2a04f729a-to-release-1.26 branch from 872bc8f to b7f2210 Compare October 23, 2023 00:24
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #7417 (b7f2210) into release-1.26 (92b763a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.26    #7417      +/-   ##
================================================
- Coverage         42.25%   42.24%   -0.02%     
================================================
  Files               128      128              
  Lines             15048    15048              
================================================
- Hits               6359     6357       -2     
- Misses             8013     8014       +1     
- Partials            676      677       +1

@kwilczynski kwilczynski force-pushed the feature/cherry-pick-2a04f729a-to-release-1.26 branch 9 times, most recently from aff3d8e to 94c2c98 Compare October 23, 2023 07:30
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Nov 9, 2023

@saschagrunert @haircommander, would there be anything left to do here?

Releases 1.28 and 1.27 are already merged.

@haircommander
Copy link
Member

haircommander commented Nov 13, 2023

/hold

we shouldn't change the golang version mid stream. We may need to chat about the way to approach this change if such a bump is required

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@kwilczynski kwilczynski force-pushed the feature/cherry-pick-2a04f729a-to-release-1.26 branch from 94c2c98 to 571ceef Compare November 13, 2023 16:14
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Nov 13, 2023

we shouldn't change the golang version mid stream. We may need to chat about the way to approach this change if such a bump is required

@haircommander, no problem! I will move it back to 1.19.

@dependabot
build(deps): bump google.golang.org/grpc from 1.51.0 to 1.58.3
f00e395 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.51.0 to 1.58.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.51.0...v1.58.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@kwilczynski kwilczynski force-pushed the feature/cherry-pick-2a04f729a-to-release-1.26 branch from 571ceef to f00e395 Compare November 13, 2023 16:28
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Nov 14, 2023

/retest-required

@kwilczynski
Copy link
Contributor Author

kwilczynski commented Nov 14, 2023

@haircommander @saschagrunert, this should be good to go.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@kwilczynski
Copy link
Contributor Author

kwilczynski commented Nov 14, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 36af4b9 into cri-o:release-1.26 Nov 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2023

@kwilczynski: Jira Issue OCPBUGS-20598: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20598 has been moved to the MODIFIED state.

Details

In response to this:

This is a manual cherry-pick of #7366

/kind dependency-change
/assign kwilczynski

Update the google.golang.org/grpc package from 1.51.0 to 1.58.3 to fix vulnerabilities CVE-2023-39325 and CVE-2023-4448.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwilczynski kwilczynski deleted the feature/cherry-pick-2a04f729a-to-release-1.26 branch November 14, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kwilczynski @openshift-ci-robot @haircommander @saschagrunert