Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.25] When crio restarts, restore the infraContainers #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-1.25] When crio restarts, restore the infraContainers #7753

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 6, 2024

This is an automated cherry-pick of #7726

/assign kwilczynski

Restore infra containers state on CRI-O restart. Without this, the infra containers will be accounted as missing, leading to a spurious error message.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 6, 2024
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 6, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub February 6, 2024 23:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic c38a539 link true /test e2e-agnostic
ci/prow/e2e-gcp c38a539 link true /test e2e-gcp
ci/prow/images c38a539 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kwilczynski
Copy link
Contributor

kwilczynski commented Feb 7, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
@sohankunkerkar
Copy link
Member

sohankunkerkar commented Feb 7, 2024

@cri-o/cri-o-maintainers PTAL

saschagrunert
saschagrunert approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

feel free to lift the hold when this is ready to land.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@kwilczynski
Copy link
Contributor

kwilczynski commented Feb 13, 2024

Superceeded by:

@kwilczynski
Copy link
Contributor

kwilczynski commented Feb 13, 2024

/close

@openshift-ci openshift-ci bot closed this Feb 13, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@kwilczynski: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@kwilczynski kwilczynski

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @kwilczynski @sohankunkerkar @saschagrunert @dsxing