[1.25] annotations: add OCI runtime specific annotations to the AllowedAnnotions #8090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations meaning an admin would have to opt-into allowing them to be used. Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
5462db9 to
0586376
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Peter Hunt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.25 #8090 +/- ##
=============================================
Coverage 43.63% 43.63%
=============================================
Files 122 122
Lines 13713 13749 +36
=============================================
+ Hits 5984 6000 +16
- Misses 7091 7108 +17
- Partials 638 641 +3 |
Member
|
/lgtm |
fabiand
added a commit
to openshift-virtualization/wasp-agent
that referenced
this pull request
May 17, 2024
Annotations are denylisted due to cri-o/cri-o#8090 and related Signed-off-by: Fabian Deutsch <[email protected]>
Barakmor1
pushed a commit
to Barakmor1/wasp-agent
that referenced
this pull request
Jul 14, 2024
Annotations are denylisted due to cri-o/cri-o#8090 and related Signed-off-by: Fabian Deutsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meaning an admin would have to opt-into allowing them to be used
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?