nri: pass around context and log failed pid for not spoofed containers #8347
Conversation
We now pass around the context to understand where the "Failed to get pid" message is coming from. We also don't have to log the message in case that the container is spoofed, otherwise the message may be misleading. Signed-off-by: Sascha Grunert <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8347 +/- ##
=======================================
Coverage 49.52% 49.53%
=======================================
Files 153 153
Lines 17069 17071 +2
=======================================
+ Hits 8454 8456 +2
Misses 7552 7552
Partials 1063 1063 |
|
/retest @cri-o/cri-o-maintainers PTAL |
|
/test ci-fedora-kata |
| if !ic.Spoofed() { | ||
| pid, err := ic.Pid() | ||
| if err != nil { | ||
| log.Debugf(ctx, "Failed to get pid for pod infra container: %v", err) |
There was a problem hiding this comment.
| log.Debugf(ctx, "Failed to get pid for pod infra container: %v", err) | |
| log.Debugf(ctx, "Failed to get PID for pod infra container: %v", err) |
|
This is excellent! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/cherry-pick release-1.30 |
|
@kannon92: new pull request created: #8435 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We now pass around the context to understand where the "Failed to get pid" message is coming from. We also don't have to log the message in case that the container is spoofed, otherwise the message may be misleading.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?