Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.30] Use custom storage check options for CRI-O internal wipe #8468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 9 commits into from
Aug 9, 2024
Merged

[release-1.30] Use custom storage check options for CRI-O internal wipe #8468

openshift-merge-bot merged 9 commits into from
Aug 9, 2024

Conversation

@kwilczynski
Copy link
Contributor

@kwilczynski kwilczynski commented Aug 9, 2024 •
edited
Loading

This is a manual cherry-pick of #8417

Note

This cherry-pick does not include the following commit:

  • a79fa8b: Make internal repair the new default and disable internal wipe

The internal repair feature will remain disabled and opt-in in CRI-O v1.30 or older.

/kind feature
/assign kwilczynski

Update the type of checks the internal repair feature performs on CRI-O's start-up following an unclean shutdown, and add a new `crio check` sub-command.

Krzysztof Wilczyński added 7 commits August 10, 2024 00:19
Use custom set of checks over the CheckEverything() for storage checks
ee8a9a4 
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Replace open-coded repair options with the RepairEverything() helper
883b312 
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Move log message from HandleUncleanShutdown() function
8f0e661 
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Make the storage shutdown force unmount images on error
059c2aa 
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Remove orphaned mounts before removing storage directory
6b61c63 
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Wipe storage only after giving storage.Repair() a chance
52d139b 
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Allow for storage directory removal to be forced
b6d27e5 
Signed-off-by: Krzysztof Wilczyński <[email protected]>
@kwilczynski kwilczynski requested a review from mrunalp as a code owner August 9, 2024 16:00
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 9, 2024
@openshift-ci openshift-ci bot requested review from QiWang19 and wgahnagl August 9, 2024 16:00
@kwilczynski kwilczynski changed the title Use custom storage check options for CRI-O internal wipe [release-1.30] Use custom storage check options for CRI-O internal wipe Aug 9, 2024
Krzysztof Wilczyński added 2 commits August 10, 2024 01:12
@kwilczynski kwilczynski force-pushed the feature/backport-8417-to-release-1.30 branch from 1d3003c to 883b1b3 Compare August 9, 2024 16:12
@haircommander
Copy link
Member

haircommander commented Aug 9, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9d7be82 into cri-o:release-1.30 Aug 9, 2024
@kwilczynski kwilczynski deleted the feature/backport-8417-to-release-1.30 branch August 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@kwilczynski kwilczynski

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kwilczynski @haircommander