default to crun #8497
Closed
default to crun #8497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5aa63fb to
81555e5
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
81555e5 to
0640d64
Compare
0640d64 to
5ef0e49
Compare
5ef0e49 to
a645175
Compare
e5d7c6e to
74dea75
Compare
ae9c9eb to
7bc9440
Compare
7bc9440 to
57ae969
Compare
d340c25 to
48c14a2
Compare
crun has been a compliant OCI runtime for many years now. It advertises faster startup time, smaller memory footprint, and additional features Given these advantages and its relative stability (and that it's the default in fedora, and podman), update crun to be the default runtime in CRI-O as well. Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
it's more idiomatic to have the setter as a validator, and call it while other aspects of the runtime handler are being validated Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
as it's not needed Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
7a7fbfd to
6c9769a
Compare
Member
Author
|
/retest |
Signed-off-by: Peter Hunt <[email protected]>
handle case where container is deleted twice Signed-off-by: Peter Hunt <[email protected]>
Member
Author
|
/retest |
Contributor
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
|
Can we close this one @haircommander ? |
Member
Author
|
yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
crun has been a compliant OCI runtime for many years now.
It advertises faster startup time, smaller memory footprint, and additional features
Given these advantages and its relative stability (and that it's the default in fedora, and podman),
update crun to be the default runtime in CRI-O as well.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?