Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the lint issue #8788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xw19 wants to merge 1 commit into from
Closed

Fix the lint issue #8788

xw19 wants to merge 1 commit into from

Conversation

@xw19
Copy link
Member

@xw19 xw19 commented Nov 27, 2024

What type of PR is this?

/kind ci

What this PR does / why we need it:

Fix lint

Which issue(s) this PR fixes:

Lint issue

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@xw19
Fix the lint issue
d969d6c 
Signed-off-by: Sourav Moitra <[email protected]>
@xw19 xw19 requested a review from mrunalp as a code owner November 27, 2024 15:12
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 27, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xw19
Once this PR has been reviewed and has the lgtm label, please assign fidencio for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

Hi @xw19. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 27, 2024
@xw19 xw19 closed this Nov 27, 2024
@kwilczynski
Copy link
Contributor

kwilczynski commented Nov 27, 2024

Already handled, see:

@kwilczynski
Copy link
Contributor

kwilczynski commented Nov 27, 2024

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xw19 @kwilczynski