[release-1.29] Fix failing test following a backport from cri-o/cri-o/pull#8795 #8807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Wilczyński <[email protected]>
We can't use them any more so we now remove it from CI. Signed-off-by: Sascha Grunert <[email protected]>
Contributor
Author
|
/assign kwilczynski |
Contributor
Author
|
/cc @cri-o/cri-o-maintainers |
saschagrunert
approved these changes
Dec 2, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind ci
/kind failing-test
What this PR does / why we need it:
To fix a failing test following a merge of the changes from Pull Request #8795, where a unit test that verifies whether a given pod sandbox ID has been set was missing the required
Metadataproperty when setting uptypes.ContainerConfigobject for use in the test.Related:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
To be merged after:
Does this PR introduce a user-facing change?`