-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release-1.34] OCPBUGS-65593: Fix CVE-2025-58183: Update tar-split to v0.12.2 #9590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.34] OCPBUGS-65593: Fix CVE-2025-58183: Update tar-split to v0.12.2 #9590
Conversation
|
@saschagrunert: No Jira issue with key CVE-2025 exists in the tracker at https://issues.redhat.com/. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
417801d to
1132fb7
Compare
|
@saschagrunert: This pull request references Jira Issue OCPBUGS-63773, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@saschagrunert: No Jira issue with key CVE-2025 exists in the tracker at https://issues.redhat.com/. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@saschagrunert: The referenced Jira(s) [CVE-2025] could not be located, all automatically applied jira labels will be removed. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@saschagrunert: No Jira issue with key CVE-2025 exists in the tracker at https://issues.redhat.com/. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.34 #9590 +/- ##
================================================
- Coverage 63.64% 63.63% -0.02%
================================================
Files 202 202
Lines 28164 28164
================================================
- Hits 17926 17922 -4
- Misses 8635 8640 +5
+ Partials 1603 1602 -1 🚀 New features to boost your workflow:
|
1132fb7 to
a68a9e0
Compare
CVE-2025-58183 is an unbounded allocation vulnerability in archive/tar when parsing GNU sparse map files. tar.Reader does not set a maximum size on the number of sparse region data blocks in GNU tar pax 1.0 sparse files. This update brings tar-split to v0.12.2 which includes the fix that caps sparse block data to 1 MiB (same limit as PAX headers). Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2407258 CVE: CVE-2025-58183 Signed-off-by: Sascha Grunert <[email protected]>
a68a9e0 to
0e11883
Compare
|
@saschagrunert: This pull request references Jira Issue OCPBUGS-65593, which is valid. The bug has been moved to the POST state. 5 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: lyman9966. Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@saschagrunert: This pull request references Jira Issue OCPBUGS-65593, which is valid. 5 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: lyman9966. Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
Merging, this seems to get stuck in the tide merge pool. |
|
@saschagrunert: Jira Issue OCPBUGS-65593: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-65593 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes CVE-2025-58183 by updating tar-split to v0.12.2.
CVE-2025-58183 is an unbounded allocation vulnerability in archive/tar when parsing GNU sparse map files. tar.Reader does not set a maximum size on the number of sparse region data blocks in GNU tar pax 1.0 sparse files. A maliciously-crafted archive containing a large number of sparse regions can cause a Reader to read an unbounded amount of data from the archive into memory.
tar-split v0.12.2 includes the fix that caps sparse block data to 1 MiB (same limit as PAX headers).
OpenShift Version: 4.21
Which issue(s) this PR fixes:
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2407258
Fixes: https://issues.redhat.com/browse/OCPBUGS-65593
Special notes for your reviewer:
This PR updates:
go.modwith tar-split v0.12.2go.sumvendor/)The vulnerability affects CRI-O's container image layer extraction code path through containers/storage which uses tar-split (a vendored fork of Go's archive/tar).
Note: No OCPBUGS JIRA issue is available for OpenShift 4.21.
Does this PR introduce a user-facing change?