Remove support for InsecureRegistries in favor of registries.conf#9511
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9511 +/- ##
==========================================
- Coverage 67.06% 66.51% -0.56%
==========================================
Files 202 202
Lines 28247 28202 -45
==========================================
- Hits 18944 18758 -186
- Misses 7708 7846 +138
- Partials 1595 1598 +3 🚀 New features to boost your workflow:
|
saschagrunert
left a comment
There was a problem hiding this comment.
LGTM, just have a non blocking nit.
internal/storage/image.go
Outdated
| secure: false, | ||
| } | ||
| } | ||
| log.Warnf(ctx, "Insecure registries option is deprecated and no longer effective. Please use `insecure` in `registries.conf` instead.") |
There was a problem hiding this comment.
I think we should error here:
| log.Warnf(ctx, "Insecure registries option is deprecated and no longer effective. Please use `insecure` in `registries.conf` instead.") | |
| log.Errorf(ctx, "Insecure registries option is deprecated and no longer effective. Please use `insecure` in `registries.conf` instead.") |
|
Ah, linter CI is not happy: /lgtm cancel |
ad17806 to
42548fc
Compare
Signed-off-by: Ayato Tokubi <[email protected]>
42548fc to
93f9201
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-gcp-ovn |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
This PR makes
insecureRegistriesno effective.Which issue(s) this PR fixes:
part of #9278
Special notes for your reviewer:
I left the option for now.
Let me know if you think it's too early to make it ineffective, or if you think we can remove it completely right now.
Does this PR introduce a user-facing change?