bump to kube and cri-o 1.35 #328
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughThis pull request updates Kubernetes-related version references from v1.34 to v1.35 across dependency metadata, documentation, and test provisioning scripts. No logic or structural configuration changes were introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Peter Hunt <[email protected]>
0fa6262 to
84d3699
Compare
|
/lgtm |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
README.mddependencies.yamltest/deb/lima.yamltest/rpm/lima.yamltest/scripts/versions.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: test / rpm / fedora:42 / s390x
- GitHub Check: test / deb / debian:13 / arm64
- GitHub Check: test / deb / ubuntu:24.04 / arm64
- GitHub Check: test / deb / debian:13 / ppc64le
- GitHub Check: test / deb / ubuntu:24.04 / s390x
- GitHub Check: test / deb / debian:13 / s390x
- GitHub Check: test / rpm / fedora:42 / arm64
- GitHub Check: test / deb / ubuntu:24.04 / ppc64le
- GitHub Check: test / rpm / almalinux:10 / arm64
- GitHub Check: test / rpm / almalinux:10 / ppc64le
- GitHub Check: test / rpm / fedora:42 / ppc64le
- GitHub Check: test / deb / kubernetes / amd64
- GitHub Check: test / rpm / kubernetes / amd64
🔇 Additional comments (6)
test/rpm/lima.yaml (1)
27-27: LGTM!The Kubernetes version update for RPM-based provisioning is consistent with the version bump across the repository.
test/deb/lima.yaml (1)
25-25: LGTM!The Kubernetes version update for Debian-based provisioning is consistent with the version bump across the repository.
test/scripts/versions.sh (1)
6-6: LGTM!The default Kubernetes version update is consistent with the version bump across the repository.
README.md (1)
157-159: LGTM!The version variable definitions are updated consistently for both Kubernetes and CRI-O to v1.35.
dependencies.yaml (2)
18-18: Version bump is approved.Kubernetes v1.35.0 was released on December 17, 2025 and includes 17 enhancements graduated to stable status. The version update is appropriate and aligns with the latest production-ready release.
4-4: Version bump to v1.35 is correct and verified.CRI-O v1.35.0 has been released and stable v1.35.z packages are available. The update aligns with the PR objective and current available releases.
|
|
||
| ```shell | ||
| curl https://raw.githubusercontent.com/cri-o/packaging/main/get | bash -s -- -t v1.34.0 | ||
| curl https://raw.githubusercontent.com/cri-o/packaging/main/get | bash -s -- -t v1.35.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
gh api repos/cri-o/cri-o/git/ref/tags/v1.35.0 --jq '.ref' 2>&1 || echo "Tag v1.35.0 not found"Repository: cri-o/packaging
Length of output: 219
🏁 Script executed:
gh api repos/cri-o/cri-o/git/refs/tags --jq '.[] | select(.ref | contains("v1.35")) | .ref' 2>&1 | head -20Repository: cri-o/packaging
Length of output: 41
🏁 Script executed:
gh api repos/cri-o/cri-o/git/refs/tags --jq '.[] | .ref' 2>&1 | head -20Repository: cri-o/packaging
Length of output: 420
🏁 Script executed:
gh api repos/cri-o/cri-o/git/refs/tags --jq '.[-20:] | .[] | .ref' 2>&1Repository: cri-o/packaging
Length of output: 419
Update the example to use an existing tag or clarify the v1.35 release timeline.
The tag v1.35.0 does not currently exist in the cri-o/cri-o repository. The latest available tags are in the v1.9.x range (v1.9.16 is the most recent). Either update the example to reference an existing tag, or document when the v1.35 release will be available.
🤖 Prompt for AI Agents
In README.md around line 337, the example uses a non-existent tag v1.35.0;
update the example to reference an actual existing tag (for example v1.9.16 or
the repository's latest release tag) or change the text to use a clearly
documented placeholder (e.g., "use the desired tag or latest release") and add a
short note pointing readers to the cri-o/cri-o tags/releases page for the
correct tag and release timeline.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.