[WIP] Detect malformed date fields when creating a new email TLO. #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: crits/emails/email.py
Contributor
|
Is this still an issue that needs addressing? I noticed you raise an exception but when it is caught you aren't using the value of the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to create a new Email TLO using the forms, if you put in a syntactically incorrect date then for the user nothing appears to happen. For example, create a new (Raw) email with the following data:
Date: Tue, 20 Oct 2015 12: 35: 00 +0200
The above has a space between the colon and minute+seconds.
This fix detects an error with the date and returns an error to the user.