-
Notifications
You must be signed in to change notification settings - Fork 258
Python3 fixes #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apolkosnik-old
wants to merge
44
commits into
crits:master
Choose a base branch
from
apolkosnik-old:python3_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Python3 fixes #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed some debug prints
…on2.7 This was causing empty dropdowns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress. Not ready for the prime time! Don't try in production!!!
Majority of heavy lifting was done by futurize here.
django-tastypie-mongoengine needs some small fixes. Too bad nobody seems to be caring much about fixing it. It looks like the maintainer chair is open for that project. I just can't get involved there.
Thus far, the front end loads, and is mostly working in Python 2 and some thing are broken in Python 3.
The broken things in Python 3 include:
Some services seem to be working too (you've got to use my python3_fixes branch for services)
I've also converted much of the services. I didn't have the patience to convert taxii_service, and stix validator (sdv actually errors out on anything but 2.x), since the libs that they use need to be converted, so I just deleted them for now. I've managed to futurize pytx, but I've got no way of testing.
I've fixed the deletion and crash on uploads, it turned out to be _id that was wrapped into a str().
The tests still fail whether for py2 or py3.
Lots of the bytes <-> str issues can be solved by converting bytes to str by the way of:
I'm not sure how much impact this might have on larger files.