This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Next release candidate #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions depend on the deprecated ethereum-* libraries instead of the newer eth-*, which cause a deprecation notice.
Manticore 0.3.6 causes issues when running etheno, see issue #80 for the details.
This is done automatically in Dockerfiles
get.parity.io does not exist anymore
The upstream bug in ganache-cli appears to have been fixed.
This fixes an issue with the dockerfile getting stuck when installing tzdata
Remove manticore integration
elopez
reviewed
Jul 8, 2022
There was a problem hiding this comment.
Great work @anishnaik! I'm commenting on a few small things I spotted on a first look
| help='Arguments to pass to truffle (default=migrate)') | ||
| parser.add_argument('-g', '--ganache', action='store_true', default=False, | ||
| help='Run Ganache as a master JSON RPC client (cannot be used in conjunction with --master)') | ||
| # TODO: This cmd-line argument is error-prone and should probably be removed. Commenting it out for now |
There was a problem hiding this comment.
the ganache-cmd by default is /usr/bin/env ganache and then you have ganache-port and then ganache-args. However, ganache-cmd could encompass all three (/usr/bin/env ganache -p 1234 --gasLimit blah blah) and if one of the other ones are also specified it might cause ganache to not start up. By removing it, everything is broken apart into independent pieces. The ability for ganache-cmd to overwrite everything else seems unnecessary...I guess error-prone is not the best language for this.
Co-authored-by: Emilio López <[email protected]>
…uest object modular Two changes: 1. Removed unused code that was dependent on using integers as the mapping for EventPlugin._transactions mapping and for converting hashes into hex strings 2. Moved get_transaction_receipt_request into etheno.py so that both clients and plugins can use itt.
Used `black` to make code PEP 8 compliant
Fix issue with function call logging and PEP 8 Compliance
elopez
reviewed
Jul 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release candidate 1 (rc-1) will be the next release of Etheno
Removal of manticore integration, echidna integration, and updating etheno to work with the latest ganache release will be merged into this before master