Provide stub dependencies for cockpit tests #690
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| class RequestException(Exception): | ||
| """Base exception for the shim.""" | ||
|
|
||
|
|
There was a problem hiding this comment.
Missing requests.exceptions namespace in shim
The new in-repo requests shim exposes RequestException and HTTPError only as top-level names, but it does not populate the standard requests.exceptions namespace. Several parts of the codebase catch errors via requests.exceptions.Timeout/RequestException (e.g. scripts/plugins.py, api/__init__.py). When this stub is imported those attributes will be absent, causing AttributeError before the cockpit CLI can execute. To be drop-in compatible, the shim should define an exceptions attribute (or module) containing aliases for these exception types.
Useful? React with 👍 / 👎.
Summary
requestsandtyperPython packages so the cockpit CLI can run inside tests without extra dependenciesdockershell wrapper used during tests to satisfy cockpit compose commandsTesting
https://chatgpt.com/codex/tasks/task_e_68f249173cf483268b07377cc10fe378