Clarify specifying the stroke attribute for symbolsStroke#3814
Open
Clarify specifying the stroke attribute for symbolsStroke#3814
Conversation
| }' /> | ||
|
|
||
| [Source](https://github.com/d3/d3-shape/blob/main/src/symbol.js) · An array containing a set of symbol types designed for stroking: [circle](#symbolCircle), [plus](#symbolPlus), [times](#symbolTimes), [triangle2](#symbolTriangle2), [asterisk](#symbolAsterisk), [square2](#symbolSquare2), and [diamond2](#symbolDiamond2). Useful for a categorical shape encoding with an [ordinal scale](../d3-scale/ordinal.md). | ||
| ** Be aware that by default SVG paths stroke attribute is set to none. By not specifying the stroke the symbols will be invisible. ** |
There was a problem hiding this comment.
Suggested change
| ** Be aware that by default SVG paths stroke attribute is set to none. By not specifying the stroke the symbols will be invisible. ** | |
| ** Please note that by default, the `stroke` attribute of SVG paths is set to "none." If the stroke is not specified, the symbols will be invisible. ** |
There was a problem hiding this comment.
Suggested a small rephrase for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with symbols I found out that it was unclear why my stroke symbols would not appear. I see in the example that the stroke attribute has to be explicitly passed. Adding a statement near the code would make sure it is clear.