Handle unsigned types when creating a table #564
Merged
+301
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned_types_when_creating_a_table
…ned_types_when_creating_a_table
Tishj
reviewed
Nov 4, 2025
…com:Tmonster/duckdb-iceberg into handle_unsigned_types_when_creating_a_table
Tishj
reviewed
Nov 4, 2025
Tishj
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to create a table with invalid types using
Create Table As. For some reason we cannot promote those types easily, maybe if we add a projection to cast them. You can create the table withCreate Table t1 ({name} {type})and the type will be cast to a valid iceberg type. Then when you insert we cast to the correct type.