Bundle core_functions extension by default #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I think this will resolve #436 as well |
sgrebnov
pushed a commit
to spiceai/duckdb-rs
that referenced
this pull request
Feb 24, 2025
# Conflicts: # crates/libduckdb-sys/duckdb.tar.gz
lukekim
pushed a commit
to spiceai/duckdb-rs
that referenced
this pull request
Feb 24, 2025
# Conflicts: # crates/libduckdb-sys/duckdb.tar.gz Co-authored-by: tk04 <[email protected]>
1 task
gadomski
added a commit
to stac-utils/rustac
that referenced
this pull request
Feb 27, 2025
gadomski
added a commit
to stac-utils/rustac
that referenced
this pull request
Feb 27, 2025
Want to pick up duckdb/duckdb-rs#437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
core_functionsextension is currently not included when using the "bundled" feature.Since it's an essential part of DuckDB and loaded on every build, this PR adds the
core_functionsextension by default, similar to how it's done with other client libraries (duckdb-node, duckdb-r, duckdb-swift, duckdb-java, etc.)