Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unbundle ICU again due to binary size #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Unbundle ICU again due to binary size #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/rust.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,10 @@ jobs:
# leak sanitization, but we don't care about backtraces here, so long
# as the other tests have them.
RUST_BACKTRACE: "0"
# We cannot run "modern-full" with asan as the chrono feature will auto-load relase binaries of
# the ICU-extension, which are not built with ASAN and will cause a crash.
run: |
cargo -Z build-std test --features "modern-full extensions-full" --target x86_64-unknown-linux-gnu --package duckdb
cargo -Z build-std test --features "serde_json url r2d2 uuid polars extensions-full" --target x86_64-unknown-linux-gnu --package duckdb
- name: publish crates --dry-run
uses: katyo/publish-crates@v2
with:
Expand Down
3 changes: 1 addition & 2 deletions crates/duckdb/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ default = []
bundled = ["libduckdb-sys/bundled"]
json = ["libduckdb-sys/json", "bundled"]
parquet = ["libduckdb-sys/parquet", "bundled"]
icu = ["libduckdb-sys/icu", "bundled"]
vscalar = []
vscalar-arrow = []
vtab = []
Expand All @@ -31,7 +30,7 @@ vtab-excel = ["vtab", "calamine"]
vtab-arrow = ["vtab", "num"]
appender-arrow = ["vtab-arrow"]
vtab-full = ["vtab-excel", "vtab-arrow", "appender-arrow"]
extensions-full = ["json", "parquet", "icu", "vtab-full"]
extensions-full = ["json", "parquet", "vtab-full"]
buildtime_bindgen = ["libduckdb-sys/buildtime_bindgen"]
modern-full = ["chrono", "serde_json", "url", "r2d2", "uuid", "polars"]
polars = ["dep:polars", "dep:polars-arrow"]
Expand Down
3 changes: 1 addition & 2 deletions crates/libduckdb-sys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ bundled = ["cc"]
buildtime_bindgen = ["bindgen", "pkg-config", "vcpkg"]
json = ["bundled"]
parquet = ["bundled"]
icu = ["bundled"]
extensions-full = ["json", "parquet", "icu"]
extensions-full = ["json", "parquet"]
winduckdb = []
# Warning: experimental feature
loadable-extension = ["prettyplease", "quote", "syn"]
Expand Down
3 changes: 0 additions & 3 deletions crates/libduckdb-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ mod build_bundled {
#[cfg(feature = "json")]
add_extension(&mut cfg, &manifest, "json", &mut cpp_files, &mut include_dirs);

#[cfg(feature = "icu")]
add_extension(&mut cfg, &manifest, "icu", &mut cpp_files, &mut include_dirs);

// duckdb/tools/pythonpkg/setup.py
cfg.define("DUCKDB_EXTENSION_AUTOINSTALL_DEFAULT", "1");
cfg.define("DUCKDB_EXTENSION_AUTOLOAD_DEFAULT", "1");
Expand Down
Binary file modified crates/libduckdb-sys/duckdb.tar.gz
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion crates/libduckdb-sys/update_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# List of extensions' sources to grab. Technically, these sources will be compiled
# but not included in the final build unless they're explicitly enabled.
EXTENSIONS = ["core_functions", "parquet", "json", "icu"]
EXTENSIONS = ["core_functions", "parquet", "json"]

# Clear the duckdb directory
try:
Expand Down
Loading