Set the default min version when min_duckdb_version is not specified #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another part of an attempt to fix duckdb/extension-template-rs#15.
The idea is the same; set a reasonable default value if no envvar is specified in order to avoid rust-analyzer crash. However, I don't come up with what value is the "reasonable default value." Probably, it can be the same as the version of libduckdb-sys, but I couldn't find nice way to acquire the value programmatically.
I also believe the value provided by extension-ci-tools, "v0.0.1", is not quite right for Rust case. As it uses the C extension API, which was officially introduced in DuckDB v1.2.0, maybe this should be "v1.2.0" unless the C extension API introduces some breaking change...?
https://github.com/duckdb/extension-ci-tools/blob/00e6af068429bf776a54f67cb1cd1ff5370a8dd7/makefiles/c_api_extensions/base.Makefile#L39-L42