Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Let Inserter accept &String and &Vec<u8> #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025
+12 −0
Merged

chore: Let Inserter accept &String and &Vec<u8> #507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b711527
Let Inserter accept &String and &Vec<u8>
yutannihilation Jun 7, 2025
b68f2d6
Tweak
yutannihilation Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions crates/duckdb/src/core/vector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ impl Inserter<&str> for FlatVector {
}
}

impl Inserter<&String> for FlatVector {
fn insert(&self, index: usize, value: &String) {
self.insert(index, value.as_str());
}
}

impl Inserter<&[u8]> for FlatVector {
fn insert(&self, index: usize, value: &[u8]) {
let value_size = value.len();
Expand All @@ -159,6 +165,12 @@ impl Inserter<&[u8]> for FlatVector {
}
}

impl Inserter<&Vec<u8>> for FlatVector {
fn insert(&self, index: usize, value: &Vec<u8>) {
self.insert(index, value.as_slice());
}
}

/// A list vector.
pub struct ListVector {
/// ListVector does not own the vector pointer.
Expand Down
Loading