Add ICU extension to the list of statically linked extensions #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mach-kernel
approved these changes
Sep 20, 2025
|
I dont think this will work, Ive attempted to do this before, but it brings the total source code size to larger than what crates.io allows, making the package upload fail. |
|
@Maxxen is right. I checked out the PR and ran The crates.io upload limit is 10MB, so adding ICU in that manner is unfortunately not an option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Query
select now() - interval '1'works via duckdb CLI, but fails viaduckdb-rswithout manually installing/loading ICU extension. In order to match the behavior of CLI, we can make it statically linked.🔨 Related Issues
#591