Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: set duckdb api to rust and add custom_user_agent config #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2024
Merged

feat: set duckdb api to rust and add custom_user_agent config #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00f7e2f
Add custom user agent config
hrl20 Jul 19, 2024
ed7943b
add test
hrl20 Jul 19, 2024
cec3eed
Merge pull request #1 from hrl20/md/duckdb-rs-custom-user-agent
hrl20 Jul 19, 2024
693a654
run formatter
hrl20 Jul 22, 2024
b00c4d3
Merge branch 'md/duckdb-rs-custom-user-agent'
hrl20 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions crates/duckdb/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ impl Config {
Ok(self)
}

/// Metadata from DuckDB callers
pub fn custom_user_agent(mut self, custom_user_agent: &str) -> Result<Config> {
self.set("custom_user_agent", custom_user_agent)?;
Ok(self)
}

/// The order type used when none is specified ([ASC] or DESC)
pub fn default_order(mut self, order: DefaultOrder) -> Result<Config> {
self.set("default_order", &order.to_string())?;
Expand Down Expand Up @@ -190,6 +196,7 @@ mod test {
.enable_object_cache(false)?
.enable_autoload_extension(true)?
.allow_unsigned_extensions()?
.custom_user_agent("test_user_agent")?
.max_memory("2GB")?
.threads(4)?
.with("preserve_insertion_order", "true")?;
Expand All @@ -215,6 +222,10 @@ mod test {
assert!(iter.next().unwrap().is_none());
assert_eq!(iter.next(), None);

let user_agent: Result<String> = db.query_row("PRAGMA USER_AGENT", [], |row| row.get(0));
let user_agent = user_agent.unwrap();
assert!(&user_agent.ends_with("rust test_user_agent"));

Ok(())
}

Expand Down
1 change: 1 addition & 0 deletions crates/duckdb/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ impl Connection {
}

let c_path = path_to_cstring(path.as_ref())?;
let config = config.with("duckdb_api", "rust").unwrap();
InnerConnection::open_with_flags(&c_path, config).map(|db| Connection {
db: RefCell::new(db),
cache: StatementCache::with_capacity(STATEMENT_CACHE_DEFAULT_CAPACITY),
Expand Down