hi @szarnyasg . I am thinking of this fix.
I will store a 3rd parameter (= offset if offset is first or NULL otherwise) in the list to track whether OFFSET is first or LIMIT is fist in the query.
If my 3rd param in list is equal to offset then offset is first in query otherwise limit is first.

But I am getting one issue that:

Assertion failed: (n < list->length), function list_nth_cell, file src_backend_nodes_list.cpp, line 313.
[1]    27093 abort      ./duckdb

I have already made a list of size 3 using list_make3, but I am getting this assertion error as the list size is 2.

hi @szarnyasg . I am thinking of this fix. I will store a 3rd parameter (= offset if offset is first or NULL otherwise) in the list to track whether OFFSET is first or LIMIT is fist in the query. If my 3rd param in list is equal to offset then offset is first in query otherwise limit is first.

But I am getting one issue that:

Assertion failed: (n < list->length), function list_nth_cell, file src_backend_nodes_list.cpp, line 313.
[1]    27093 abort      ./duckdb

I have already made a list of size 3 using list_make3, but I am getting this assertion error as the list size is 2.

I would assume the problem is NOT from one of the places you changed list_make2 -> list_make3, but from other places, like https://github.com/duckdb/duckdb/pull/15484/files#diff-42899531f1aa9bacd2fe999bc94bb896abf1f37503d19993b8b6b0d9a9cf82d1R650.

That said, this is just a hunch, I don't have experience with parsers, other might have a better answer to this. I also can't immediately how this solves the issue the problem, but I guess passing this information down further will.

Be aware that waiting days for a PR review might be expected.

hi @szarnyasg . I am thinking of this fix. I will store a 3rd parameter (= offset if offset is first or NULL otherwise) in the list to track whether OFFSET is first or LIMIT is fist in the query. If my 3rd param in list is equal to offset then offset is first in query otherwise limit is first.
But I am getting one issue that:

Assertion failed: (n < list->length), function list_nth_cell, file src_backend_nodes_list.cpp, line 313.
[1]    27093 abort      ./duckdb

I have already made a list of size 3 using list_make3, but I am getting this assertion error as the list size is 2.

I would assume the problem is NOT from one of the places you changed list_make2 -> list_make3, but from other places, like https://github.com/duckdb/duckdb/pull/15484/files#diff-42899531f1aa9bacd2fe999bc94bb896abf1f37503d19993b8b6b0d9a9cf82d1R650.

That said, this is just a hunch, I don't have experience with parsers, other might have a better answer to this. I also can't immediately how this solves the issue the problem, but I guess passing this information down further will.

Be aware that waiting days for a PR review might be expected.

thanks for the reply @carlopi

opt_select_limit:
	select_limit						{ $$ = $1; }
	| /* EMPTY */						{ $$ = list_make3(NULL,NULL,NULL); }

here select_limit should return list_make3, so I think this should work

Thanks for the PR! The changes seems fine to me but it seems to not be working correctly currently. Can you look at the CI failures?

Thanks for the PR! The changes seems fine to me but it seems to not be working correctly currently. Can you look at the CI failures?

Hi @Mytherin I have fixed the PR. Its working now.

@Mytherin I have added test cases as well

hey @Mytherin @szarnyasg. Did you get a chance to review this PR

Thanks - the changes look good

hi @Mytherin This is my first PR to duckdb. Any ETA when this can be merged?
I would love to be part of the contributors list.

We'll merge it in the coming weeks after the release

Thanks!