Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JasonPunyon
Copy link
Contributor

@JasonPunyon JasonPunyon commented Feb 3, 2025

This PR:

  1. Fixes a comment.

@Mytherin
Copy link
Collaborator

Thanks for the PR!

I'm not so sure this is removing a duplicate check for has_estimated_cardinality. EstimateCardinality is a virtual method and not all inherited methods check for this. I would leave that code as-is for now.

@JasonPunyon
Copy link
Contributor Author

Ok, just the comment then. Thanks for suffering my goof. Appreciate the explanation.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 17, 2025 20:42
@Mytherin Mytherin marked this pull request as ready for review February 17, 2025 21:17
@Mytherin Mytherin merged commit 7e72364 into duckdb:main Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants