Modify histogram test to more fuzzily check boundaries since the test can be inconsistent on different platforms#16261
Merged
Mytherin merged 2 commits intoduckdb:mainfrom Feb 17, 2025
Merged
Conversation
…ent on different platforms
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Mar 4, 2025
[Dev] Fix issue in `TRY` expression with `dictionary_expression` Vector verification (duckdb/duckdb#16262) Modify histogram test to more fuzzily check boundaries since the test can be inconsistent on different platforms (duckdb/duckdb#16261)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
[Dev] Fix issue in `TRY` expression with `dictionary_expression` Vector verification (duckdb/duckdb#16262) Modify histogram test to more fuzzily check boundaries since the test can be inconsistent on different platforms (duckdb/duckdb#16261)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
[Dev] Fix issue in `TRY` expression with `dictionary_expression` Vector verification (duckdb/duckdb#16262) Modify histogram test to more fuzzily check boundaries since the test can be inconsistent on different platforms (duckdb/duckdb#16261)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
[Dev] Fix issue in `TRY` expression with `dictionary_expression` Vector verification (duckdb/duckdb#16262) Modify histogram test to more fuzzily check boundaries since the test can be inconsistent on different platforms (duckdb/duckdb#16261)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
[Dev] Fix issue in `TRY` expression with `dictionary_expression` Vector verification (duckdb/duckdb#16262) Modify histogram test to more fuzzily check boundaries since the test can be inconsistent on different platforms (duckdb/duckdb#16261)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Dev] Fix issue in `TRY` expression with `dictionary_expression` Vector verification (duckdb/duckdb#16262) Modify histogram test to more fuzzily check boundaries since the test can be inconsistent on different platforms (duckdb/duckdb#16261)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Histogram boundaries do a bunch of floating point arithmetic that is not consistent on all platforms - and we don't really care if the boundaries are exactly equivalent to a certain value.